Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Issue 1230953005: Allow "Run all plugins this time" if managed setting is click to play. (Closed)

Created:
5 years, 5 months ago by Will Harris
Modified:
5 years, 5 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow "Run all plugins this time" if managed setting is click to play. BUG=509169 TEST=set DefaultPluginsSetting to 3, visit site with Flash, verify "Run all plugins this time" link is enabled. Committed: https://crrev.com/f71489f2413304bd5e9ff7ac58f96955eec91346 Cr-Commit-Position: refs/heads/master@{#338510}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/ui/content_settings/content_setting_bubble_model.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Will Harris
PTAL
5 years, 5 months ago (2015-07-11 22:17:08 UTC) #2
Bernhard Bauer
lgtm
5 years, 5 months ago (2015-07-13 08:35:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1230953005/1
5 years, 5 months ago (2015-07-13 14:33:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-13 15:28:35 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-13 15:29:31 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f71489f2413304bd5e9ff7ac58f96955eec91346
Cr-Commit-Position: refs/heads/master@{#338510}

Powered by Google App Engine
This is Rietveld 408576698