Patch 3.1: Refactored spellcheck_message_filter to be generic

chrome/browser/spellchecker/spellcheck_message_filter_platform_android.cc

Index: chrome/browser/spellchecker/spellcheck_message_filter_platform_android.cc
diff --git a/chrome/browser/spellchecker/spellcheck_message_filter_platform_android.cc b/chrome/browser/spellchecker/spellcheck_message_filter_platform_android.cc
new file mode 100644
index 0000000000000000000000000000000000000000..3c8711b5ecf51be0268d356774261479ebb77a4f
--- /dev/null
+++ b/chrome/browser/spellchecker/spellcheck_message_filter_platform_android.cc
@@ -0,0 +1,87 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/spellchecker/spellcheck_message_filter_platform.h"
+
+#include <algorithm>

[please use gerrit instead, 2015/07/10 00:20:54]

Please remove this unused #include.

[dylanking, 2015/07/10 02:21:23]

Done.

+#include <functional>

[please use gerrit instead, 2015/07/10 00:20:55]

Please remove this unused #include.

[dylanking, 2015/07/10 02:21:23]

Done.

+
+#include "base/barrier_closure.h"

[please use gerrit instead, 2015/07/10 00:20:55]

Please remove this unused #include.

[dylanking, 2015/07/10 02:21:23]

Done.

+#include "base/bind.h"

[please use gerrit instead, 2015/07/10 00:20:54]

Please remove this unused #include.

[dylanking, 2015/07/10 02:21:23]

Done.

+#include "chrome/browser/spellchecker/feedback_sender.h"

[please use gerrit instead, 2015/07/10 00:20:54]

Please remove this unused #include.

[dylanking, 2015/07/10 02:21:23]

Done.

+#include "chrome/browser/spellchecker/spellcheck_factory.h"

[please use gerrit instead, 2015/07/10 00:20:55]

Please remove this unused #include.

[dylanking, 2015/07/10 02:21:23]

Done.

+#include "chrome/browser/spellchecker/spellcheck_platform_mac.h"

[please use gerrit instead, 2015/07/10 00:20:54]

Please remove this unused #include.

[dylanking, 2015/07/10 02:21:22]

Done.

+#include "chrome/browser/spellchecker/spellcheck_service.h"

[please use gerrit instead, 2015/07/10 00:20:54]

Please remove this unused #include.

[dylanking, 2015/07/10 02:21:23]

Done.

+#include "chrome/browser/spellchecker/spelling_service_client.h"
+#include "chrome/common/spellcheck_messages.h"
+#include "chrome/common/spellcheck_result.h"
+#include "content/public/browser/browser_context.h"
+#include "content/public/browser/render_process_host.h"

[please use gerrit instead, 2015/07/10 00:20:55]

Please remove this unused #include.

[dylanking, 2015/07/10 02:21:23]

Done.

+
+using content::BrowserThread;
+using content::BrowserContext;

[please use gerrit instead, 2015/07/10 00:20:54]

Please remove this unused "using".

[dylanking, 2015/07/10 02:21:22]

Done.

+
+namespace {
+
+bool CompareLocation(const SpellCheckResult& r1,

[please use gerrit instead, 2015/07/10 00:20:55]

Please remove this unused function.

[dylanking, 2015/07/10 02:21:23]

Done.

+                     const SpellCheckResult& r2) {
+}
+
+}  // namespace
+
+SpellCheckMessageFilterPlatform::SpellCheckMessageFilterPlatform(
+    int render_process_id)
+    : BrowserMessageFilter(SpellCheckMsgStart),
+      render_process_id_(render_process_id),
+      client_(new SpellingServiceClient) {

[please use gerrit instead, 2015/07/10 00:20:54]

Please ask Aurimas whether Android will support "Ask Google for suggestions"
option in spellchecker. If not, then there is no need to instantiate
SpellingServiceClient. (It's used to communicate to the Google spellchecker in
the cloud.)

[dylanking, 2015/07/10 02:21:23]

This is a stretch goal, so for now we'll leave client_ null. 

+}
+
+void SpellCheckMessageFilterPlatform::OverrideThreadForMessage(
+    const IPC::Message& message, BrowserThread::ID* thread) {
+}
+
+bool SpellCheckMessageFilterPlatform::OnMessageReceived(
+    const IPC::Message& message) {
+}
+
+// static
+void SpellCheckMessageFilterPlatform::CombineResults(
+    std::vector<SpellCheckResult>* remote_results,
+    const std::vector<SpellCheckResult>& local_results) {
+}
+
+SpellCheckMessageFilterPlatform::~SpellCheckMessageFilterPlatform() {}
+
+void SpellCheckMessageFilterPlatform::OnCheckSpelling(
+    const base::string16& word,
+    int route_id,
+    bool* correct) {
+}
+
+void SpellCheckMessageFilterPlatform::OnFillSuggestionList(
+    const base::string16& word,
+    std::vector<base::string16>* suggestions) {
+}
+
+void SpellCheckMessageFilterPlatform::OnShowSpellingPanel(bool show) {
+}
+
+void SpellCheckMessageFilterPlatform::OnUpdateSpellingPanelWithMisspelledWord(
+    const base::string16& word) {
+}
+
+void SpellCheckMessageFilterPlatform::OnRequestTextCheck(
+    int route_id,
+    int identifier,
+    const base::string16& text,
+    std::vector<SpellCheckMarker> markers) {
+}
+
+int SpellCheckMessageFilterPlatform::ToDocumentTag(int route_id) {
+    NOTREACHED();
+}
+
+void SpellCheckMessageFilterPlatform::RetireDocumentTag(int route_id) {
+    NOTREACHED();
+}