build/common.gypi - Issue 1230933002: Patch 3.1: Refactored spellcheck_message_filter to be generic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 1230933002: Patch 3.1: Refactored spellcheck_message_filter to be generic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@platform_flag

Patch Set: Updated gn build variable to match gyp side Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index cc48129203b482ed8ac59c23fa60bbb2cc657560..3f298a67557ee6029d934a6b432aa17c50098e5c 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -811,7 +811,6 @@

'enable_extensions%': 0,

'enable_google_now%': 0,

'cld_version%': 1,

- 'enable_spellcheck%': 0,

'enable_themes%': 0,

'remoting%': 0,

'arm_neon%': 0,

@@ -823,8 +822,8 @@

'video_hole%': 1,

}],

- # OSX has a built-in spellchecker can be utilized.

- ['OS=="mac"', {

+ # Android and OSX have built-in spellcheckers that can be utilized.

+ ['OS=="android" or OS=="mac"', {

'use_platform_spellchecker%': 1,

}],

« no previous file with comments | « no previous file | build/config/features.gni » ('j') | no next file with comments »