Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2896)

Unified Diff: chrome/browser/spellchecker/spellcheck_message_filter_mac_browsertest.cc

Issue 1230933002: Patch 3.1: Refactored spellcheck_message_filter to be generic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@platform_flag
Patch Set: Updated gn build variable to match gyp side Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/spellchecker/spellcheck_message_filter_mac_browsertest.cc
diff --git a/chrome/browser/spellchecker/spellcheck_message_filter_mac_browsertest.cc b/chrome/browser/spellchecker/spellcheck_message_filter_mac_browsertest.cc
deleted file mode 100644
index 6e47f7de57b7ba4820215e2af56525cbcf1c7dcd..0000000000000000000000000000000000000000
--- a/chrome/browser/spellchecker/spellcheck_message_filter_mac_browsertest.cc
+++ /dev/null
@@ -1,63 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "base/command_line.h"
-#include "base/memory/scoped_vector.h"
-#include "base/message_loop/message_loop.h"
-#include "base/stl_util.h"
-#include "base/strings/utf_string_conversions.h"
-#include "chrome/browser/spellchecker/spellcheck_message_filter_mac.h"
-#include "chrome/common/spellcheck_messages.h"
-#include "chrome/common/spellcheck_result.h"
-#include "chrome/test/base/in_process_browser_test.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-// Fake filter for testing, which stores sent messages and
-// allows verification by the test case.
-class TestingSpellCheckMessageFilter : public SpellCheckMessageFilterMac {
- public:
- explicit TestingSpellCheckMessageFilter(base::MessageLoopForUI* loop)
- : SpellCheckMessageFilterMac(0),
- loop_(loop) { }
-
- bool Send(IPC::Message* message) override {
- sent_messages_.push_back(message);
- loop_->PostTask(FROM_HERE, base::MessageLoop::QuitClosure());
- return true;
- }
-
- ScopedVector<IPC::Message> sent_messages_;
- base::MessageLoopForUI* loop_;
-
- private:
- ~TestingSpellCheckMessageFilter() override {}
-};
-
-typedef InProcessBrowserTest SpellCheckMessageFilterMacBrowserTest;
-
-// Uses browsertest to setup chrome threads.
-IN_PROC_BROWSER_TEST_F(SpellCheckMessageFilterMacBrowserTest,
- SpellCheckReturnMessage) {
- scoped_refptr<TestingSpellCheckMessageFilter> target(
- new TestingSpellCheckMessageFilter(base::MessageLoopForUI::current()));
-
- SpellCheckHostMsg_RequestTextCheck to_be_received(
- 123, 456, base::UTF8ToUTF16("zz."), std::vector<SpellCheckMarker>());
- target->OnMessageReceived(to_be_received);
-
- base::MessageLoopForUI::current()->Run();
- EXPECT_EQ(1U, target->sent_messages_.size());
-
- SpellCheckMsg_RespondTextCheck::Param params;
- bool ok = SpellCheckMsg_RespondTextCheck::Read(
- target->sent_messages_[0], &params);
- std::vector<SpellCheckResult> sent_results = base::get<2>(params);
-
- EXPECT_TRUE(ok);
- EXPECT_EQ(1U, sent_results.size());
- EXPECT_EQ(sent_results[0].location, 0);
- EXPECT_EQ(sent_results[0].length, 2);
- EXPECT_EQ(sent_results[0].decoration,
- SpellCheckResult::SPELLING);
-}

Powered by Google App Engine
This is Rietveld 408576698