chrome/browser/spellchecker/spellcheck_message_filter_mac_browsertest.cc - Issue 1230933002: Patch 3.1: Refactored spellcheck_message_filter to be generic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/spellchecker/spellcheck_message_filter_mac_browsertest.cc

Issue 1230933002: Patch 3.1: Refactored spellcheck_message_filter to be generic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@platform_flag

Patch Set: Reverted a changed reference to a class that wasn't changed Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chrome_content_browser_client.cc ('K') | « chrome/browser/spellchecker/spellcheck_message_filter_mac.cc ('k') | chrome/browser/spellchecker/spellcheck_message_filter_mac_unittest.cc » ('j') | chrome/browser/spellchecker/spellcheck_message_filter_mac_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/spellchecker/spellcheck_message_filter_mac_browsertest.cc

diff --git a/chrome/browser/spellchecker/spellcheck_message_filter_mac_browsertest.cc b/chrome/browser/spellchecker/spellcheck_message_filter_mac_browsertest.cc

index 08ef6c68860fff2b3bb22fe53bc86c009c33a85f..f342cc2fe3e5af6a6d94a0163e43bcfbea57fd35 100644

--- a/chrome/browser/spellchecker/spellcheck_message_filter_mac_browsertest.cc

+++ b/chrome/browser/spellchecker/spellcheck_message_filter_mac_browsertest.cc

@@ -7,7 +7,7 @@

#include "base/message_loop/message_loop.h"

#include "base/stl_util.h"

#include "base/strings/utf_string_conversions.h"

-#include "chrome/browser/spellchecker/spellcheck_message_filter_mac.h"

+#include "chrome/browser/spellchecker/spellcheck_message_filter_platform.h"

please use gerrit instead 2015/07/09 22:21:29 Please move this #include to the top of the #inclu

dylanking 2015/07/09 23:49:57 Reverted, though this is giving me presubmit warni

#include "chrome/common/spellcheck_messages.h"

#include "chrome/common/spellcheck_result.h"

#include "chrome/test/base/in_process_browser_test.h"