Issue 1230923005: Fix -Wreorder warnings in the Windows code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1230923005: Fix -Wreorder warnings in the Windows code. (Closed)

Created:
5 years, 5 months ago by Nico

Modified:
5 years, 5 months ago

Reviewers:
Will Harris

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/src/

Visibility:
Public.

More Reviews

Description

Fix -Wreorder warnings in the Windows code. This makes the order of fields in constructor initializer lists match the order in which the fields are declared in (which is the order they're initialized in). No intended behavior change. BUG=chromium:505304

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -14 lines)			Patch
M	client/windows/crash_generation/crash_generation_client.cc	View	2 chunks	+8 lines, -8 lines	0 comments	Download
M	client/windows/crash_generation/crash_generation_server.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	client/windows/crash_generation/minidump_generator.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Nico

Will, looks like you've landed stuff in this directory before. Since Mark is out, can ...

5 years, 5 months ago (2015-07-10 16:42:31 UTC) #2

Will Harris

5 years, 5 months ago (2015-07-10 20:25:06 UTC) #5

On 2015/07/10 17:57:23, Nico wrote:
> Thanks! Can you land this?

landed in https://codereview.chromium.org/1234653002/

had to land with src/ prefix so just created a new CL...

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages