fixes #6, refactor to use AnalysisError/Listener throughout dev_compiler

lib/src/dependency_graph.dart

Index: lib/src/dependency_graph.dart
diff --git a/lib/src/dependency_graph.dart b/lib/src/dependency_graph.dart
index dd39df563512aea9c309a464613c4e10ff77cf96..0600b59d1d60faccd4e69b0d81932390989def2c 100644
--- a/lib/src/dependency_graph.dart
+++ b/lib/src/dependency_graph.dart
@@ -21,6 +21,7 @@ import 'package:analyzer/src/generated/ast.dart'
         UriBasedDirective;
 import 'package:analyzer/src/generated/engine.dart'
     show ParseDartTask, AnalysisContext;
+import 'package:analyzer/src/generated/error.dart';
 import 'package:analyzer/src/generated/source.dart' show Source, SourceKind;
 import 'package:html/dom.dart' show Document, Node, Element;
 import 'package:html/parser.dart' as html;
@@ -44,7 +45,7 @@ class SourceGraph {
 
   /// Analyzer used to resolve source files.
   final AnalysisContext _context;
-  final CompilerReporter _reporter;
+  final AnalysisErrorListener _reporter;
   final CompilerOptions _options;
 
   SourceGraph(this._context, this._reporter, this._options) {
@@ -181,7 +182,10 @@ class HtmlSourceNode extends SourceNode {
   void update() {
     super.update();
     if (needsRebuild) {
-      graph._reporter.clearHtml(uri);
+      var reporter = graph._reporter;
+      if (reporter is SummaryReporter) {
+        reporter.clearHtml(uri);
+      }
       document = html.parse(contents, generateSpans: true);
       var newScripts = new Set<DartSourceNode>();
       var tags = document.querySelectorAll('script[type="application/dart"]');
@@ -232,11 +236,12 @@ class HtmlSourceNode extends SourceNode {
   }
 
   void _reportError(SourceGraph graph, String message, Node node) {
-    graph._reporter.enterHtml(_source.uri);
     var span = node.sourceSpan;
-    graph._reporter.log(
-        new Message(message, Level.SEVERE, span.start.offset, span.end.offset));
-    graph._reporter.leaveHtml();
+
+    // TODO(jmesserly): should these be errors or warnings?

[vsm, 2015/07/09 23:54:07]

Mostly look like real errors (e.g., inline scripts not supported, file not
found).

[Jennifer Messerly, 2015/07/10 16:12:05]

yeah, maybe ... on the other hand, HTML doesn't really have a notion of
"errors", at least not in the sense that blocks rendering. HTML parse errors
aren't even usually displayed normally, except by linters. (which is kind of a
shame, because there's a lot of useful parse errors in the spec!)

similarly, html errors don't really affect soundness (at least I hope so ;-) )
... so if we treat them as warnings, worst case, your app won't load, best cast,
maybe you can still develop some other parts (like the CSS). if we don't
generate the HTML file ... your app totally won't load. e.g. for inline scripts,
maybe you have one inline script and one src= script, you could still debug the
src= app even if the inline one doesn't work.

it also depends on --force-compile ... if we have that on always for --server,
then we have less incentive to lower the error level.

anyway, not saying I'm in favor of warnings, just don't know that it's clear
cut. Seemed worth adding a TODO at least :)

+    var errorCode = new HtmlWarningCode('dev_compiler.$runtimeType', message);
+    graph._reporter.onError(new AnalysisError(
+        _source, span.start.offset, span.length, errorCode));
   }
 }
 
@@ -281,7 +286,11 @@ class DartSourceNode extends SourceNode {
     super.update();
 
     if (needsRebuild) {
-      graph._reporter.clearLibrary(uri);
+      var reporter = graph._reporter;
+      if (reporter is SummaryReporter) {
+        reporter.clearLibrary(uri);
+      }
+
       // If the defining compilation-unit changed, the structure might have
       // changed.
       var unit = parseDirectives(contents, name: _source.fullName);
@@ -306,7 +315,7 @@ class DartSourceNode extends SourceNode {
             targetUri, () => new DartSourceNode(graph, targetUri, target));
         //var node = graph.nodeFromUri(targetUri);
         if (node._source == null || !node._source.exists()) {
-          _reportError(graph, 'File $targetUri not found', unit, d);
+          _reportError(graph, 'File $targetUri not found', d);
         }
 
         if (d is ImportDirective) {
@@ -360,14 +369,9 @@ class DartSourceNode extends SourceNode {
     }
   }
 
-  void _reportError(
-      SourceGraph graph, String message, CompilationUnit unit, AstNode node) {
-    graph._reporter
-      ..enterLibrary(_source.uri)
-      ..enterCompilationUnit(unit, _source)
-      ..log(new Message(message, Level.SEVERE, node.offset, node.end))
-      ..leaveCompilationUnit()
-      ..leaveLibrary();
+  void _reportError(SourceGraph graph, String message, AstNode node) {
+    graph._reporter.onError(new AnalysisError(_source, node.offset,
+        node.length, new CompileTimeErrorCode('dev_compiler.$runtimeType', message)));
   }
 }