Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1230893002: Rebaseline tests after f66984e72a2b5db0f7c4db4f05829118defe6640 (Closed)

Created:
5 years, 5 months ago by abarth-chromium
Modified:
5 years, 5 months ago
Reviewers:
mpcomplete, Hixie
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Rebaseline tests after f66984e72a2b5db0f7c4db4f05829118defe6640 TBR=mpcomplete@google.com Committed: https://chromium.googlesource.com/external/mojo/+/aa2b09f7d2d6a0aa243506ee24de29c202f1a572

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+941 lines, -859 lines) Patch
M sky/tests/examples/sector-expected.txt View 7 chunks +516 lines, -474 lines 0 comments Download
M sky/tests/examples/stocks-expected.txt View 4 chunks +102 lines, -90 lines 0 comments Download
M sky/tests/examples/styled_text-expected.txt View 1 chunk +99 lines, -97 lines 0 comments Download
M sky/tests/examples/tabs-expected.txt View 2 chunks +121 lines, -115 lines 0 comments Download
M sky/tests/widgets/buttons-expected.txt View 3 chunks +30 lines, -24 lines 1 comment Download
M sky/tests/widgets/dialog-expected.txt View 1 chunk +19 lines, -17 lines 0 comments Download
M sky/tests/widgets/syncs1-expected.txt View 6 chunks +54 lines, -42 lines 1 comment Download

Messages

Total messages: 5 (1 generated)
abarth-chromium
5 years, 5 months ago (2015-07-09 19:10:55 UTC) #1
abarth-chromium
Committed patchset #1 (id:1) manually as aa2b09f7d2d6a0aa243506ee24de29c202f1a572 (presubmit successful).
5 years, 5 months ago (2015-07-09 19:11:20 UTC) #2
Hixie
I am concerned that this is papering over real bugs. @mpcomplete https://codereview.chromium.org/1230893002/diff/1/sky/tests/widgets/buttons-expected.txt File sky/tests/widgets/buttons-expected.txt (right): ...
5 years, 5 months ago (2015-07-09 20:56:08 UTC) #4
Matt Perry
5 years, 5 months ago (2015-07-09 20:59:49 UTC) #5
Message was sent while issue was closed. 
On 2015/07/09 20:56:08, Hixie wrote:
> I am concerned that this is papering over real bugs.

Yep, good catch. I broke stuff, https://codereview.chromium.org/1224223004/
fixes it (and restores the test expectations, except for a small change to
sector-expected due to animating bg color changes).

Powered by Google App Engine
This is Rietveld 408576698