Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 1230833003: Roll breakpad 1465:1471 (Closed)

Created:
5 years, 5 months ago by Nico
Modified:
5 years, 5 months ago
Reviewers:
Will Harris
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll breakpad 1465:1471 1471 Fix -Wreorder warnings in the Windows code. 1470 Default nil or empty version string to CFBundleVersion 1469 Set exception whitelist check as earlier check instead of last check. 1468 Use general instruction/stack pointer convenience method instead of manually 1467 Checking for benign exceptions that trigger a minidump. 1466 This CL adds support for ARM and ARM64 architectures when calculating BUG=505304 R=wfh@chromium.org TBR=wfh@chromium.org

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Nico
5 years, 5 months ago (2015-07-10 20:37:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1230833003/1
5 years, 5 months ago (2015-07-10 20:38:16 UTC) #3
Will Harris
just checking you meant to roll angle too?
5 years, 5 months ago (2015-07-10 20:55:40 UTC) #5
Nico
I branched off the wrong branch, sorry. angle was https://chromium.googlesource.com/chromium/src/+/c88b566b542e6f373769c36777be782d59c7c7c2 (already in). reuploaded, should look ...
5 years, 5 months ago (2015-07-10 20:58:43 UTC) #6
Will Harris
lgtm
5 years, 5 months ago (2015-07-10 21:00:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1230833003/20001
5 years, 5 months ago (2015-07-10 21:01:33 UTC) #9
Nico
5 years, 5 months ago (2015-07-10 21:16:36 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) to pending queue manually as
9728e90fd2f8c88c6752c0116f6827d6390596ff (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698