Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 1230833002: BlockViewport didn't implement the intrinsic dimension functions correctly. (Closed)

Created:
5 years, 5 months ago by Hixie
Modified:
5 years, 5 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

BlockViewport didn't implement the intrinsic dimension functions correctly. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/539b6d9ca13f03b8f646924fe1d6bab3be4e3444

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -44 lines) Patch
M sky/sdk/lib/rendering/block.dart View 3 chunks +60 lines, -44 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm
5 years, 5 months ago (2015-07-09 16:53:09 UTC) #2
Hixie
5 years, 5 months ago (2015-07-09 16:57:07 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
539b6d9ca13f03b8f646924fe1d6bab3be4e3444 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698