Issue 1230823007: Revert of guard to remove DrawBitmapRectFlags

Issue 1230823007: Revert of guard to remove DrawBitmapRectFlags (Closed)

Created:
5 years, 5 months ago by scroggo

Modified:
5 years, 5 months ago

Reviewers:
f(malita), djsollen, reed2

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert of guard to remove DrawBitmapRectFlags (patchset #1 id:1 of https://codereview.chromium.org/1235393003/) Reason for revert: breaking android framework build Original issue's description: > guard to remove DrawBitmapRectFlags > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/6fb0b6779e40ce05c20cf279f0ecff31fa3cd60d TBR=fmalita@chromium.org,djsollen@google.com,reed@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/91110195a2eee170c11885da9d16f94b00a39f87

Patch Set 1 #

Created: 5 years, 5 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+55 lines, -76 lines)			Patch
M	bench/BitmapRectBench.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	bench/GameBench.cpp	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	gm/bitmaprect.cpp	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	gm/drawbitmaprect.cpp	View	4 chunks	+19 lines, -14 lines	0 comments	Download
M	gm/tallstretchedbitmaps.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gm/verylargebitmap.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gyp/skia_for_android_framework_defines.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	include/core/SkCanvas.h	View	4 chunks	+6 lines, -18 lines	0 comments	Download
M	samplecode/SampleApp.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	samplecode/SampleBitmapRect.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	samplecode/SampleTextureDomain.cpp	View	3 chunks	+4 lines, -3 lines	0 comments	Download
M	src/core/SkCanvas.cpp	View	4 chunks	+0 lines, -14 lines	0 comments	Download
M	src/effects/SkTestImageFilters.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/SkGr.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/utils/SkNinePatch.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/utils/debugger/SkDrawCommand.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/DrawBitmapRectTest.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/PictureTest.cpp	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	tests/SurfaceTest.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1230823007/1

5 years, 5 months ago (2015-07-17 12:57:24 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/91110195a2eee170c11885da9d16f94b00a39f87

5 years, 5 months ago (2015-07-17 12:57:39 UTC) #3

scroggo

On 2015/07/17 12:57:39, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...

5 years, 5 months ago (2015-07-17 13:45:31 UTC) #4

scroggo

5 years, 5 months ago (2015-07-17 13:47:11 UTC) #5

Message was sent while issue was closed.

On 2015/07/17 13:45:31, scroggo wrote:
> On 2015/07/17 12:57:39, commit-bot: I haz the power wrote:
> > Committed patchset #1 (id:1) as
> >
https://skia.googlesource.com/skia/+/91110195a2eee170c11885da9d16f94b00a39f87
> 
> I should have mentioned, the error (for those who can see it) is here:
>
https://android-build.storage.googleapis.com/builds/git_master-skia-linux-raz...

I assume noone can see it. I cannot...

Expand Messages | Collapse Messages