Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1230823005: V8 project metadata (Closed)

Created:
5 years, 5 months ago by nodir
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

V8 project metadata Added project.cfg metadata file for chrome-infra R=machenbach@chromium.org, sergiyb@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=507723 Committed: https://crrev.com/0337fedf52b0d55bb7a2dfc3cdf9cb314f8b80bf Cr-Commit-Position: refs/heads/master@{#29613}

Patch Set 1 #

Total comments: 2

Patch Set 2 : v8 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
A infra/project-config/project.cfg View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
nodir
PTAL. A similar project.cfg went to chromium https://codereview.chromium.org/1223973002/
5 years, 5 months ago (2015-07-13 13:16:52 UTC) #1
Michael Achenbach
lgtm https://codereview.chromium.org/1230823005/diff/1/infra/project-config/project.cfg File infra/project-config/project.cfg (right): https://codereview.chromium.org/1230823005/diff/1/infra/project-config/project.cfg#newcode4 infra/project-config/project.cfg:4: name: "V8 JavaScript engine" How about just V8? ...
5 years, 5 months ago (2015-07-13 14:34:57 UTC) #2
nodir
https://codereview.chromium.org/1230823005/diff/1/infra/project-config/project.cfg File infra/project-config/project.cfg (right): https://codereview.chromium.org/1230823005/diff/1/infra/project-config/project.cfg#newcode4 infra/project-config/project.cfg:4: name: "V8 JavaScript engine" On 2015/07/13 14:34:57, Michael Achenbach ...
5 years, 5 months ago (2015-07-13 14:40:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1230823005/20001
5 years, 5 months ago (2015-07-13 14:40:24 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-13 14:40:35 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-13 14:40:55 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0337fedf52b0d55bb7a2dfc3cdf9cb314f8b80bf
Cr-Commit-Position: refs/heads/master@{#29613}

Powered by Google App Engine
This is Rietveld 408576698