Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(22)

Issue 12308006: Merge 142793 (Closed)

Created:
7 years, 9 months ago by leviw_travelin_and_unemployed
Modified:
7 years, 9 months ago
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1410/
Visibility:
Public.

Description

Merge 142793 > Bidi-Isolated inlines can cause subsequent content to not be rendered > https://bugs.webkit.org/show_bug.cgi?id=108137 > > Reviewed by Eric Seidel. > > Source/WebCore: > > First step in fixing how inline isolates behave with collapsed spaces. > webkit.org/b/109624 tracks the overarching issue. > > Test: fast/text/content-following-inline-isolate-with-collapsed-whitespace.html > > * rendering/InlineIterator.h: > (WebCore::IsolateTracker::addFakeRunIfNecessary): If we enter an isolate while > ignoring spaces, ensure we leave it considering them again. This can result in > including spaces that should be ignored following the isolate on the line, but > failing to do so results in those contents not being rendered at all. > > LayoutTests: > > * fast/text/content-following-inline-isolate-with-collapsed-whitespace.html: Added. > * fast/text/content-following-inline-isolate-with-collapsed-whitespace-expected.txt: Added. > TBR=leviw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143365

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, --2 lines) Patch
A + LayoutTests/fast/text/content-following-inline-isolate-with-collapsed-whitespace.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/text/content-following-inline-isolate-with-collapsed-whitespace-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/rendering/InlineIterator.h View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
leviw_travelin_and_unemployed
7 years, 9 months ago (2013-02-19 19:29:50 UTC) #1
leviw_travelin_and_unemployed
7 years, 9 months ago (2013-02-19 19:32:30 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r143365.

Powered by Google App Engine
This is Rietveld 408576698