Initial support for the desktop media pipeline on Android.

media/ffmpeg/ffmpeg_common.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/ffmpeg/ffmpeg_common.h"
 
 #include "base/basictypes.h"
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "base/strings/string_number_conversions.h"
@@ skipping 389 matching lines @@
   if (record_stats) {
     // Note the PRESUBMIT_IGNORE_UMA_MAX below, this silences the PRESUBMIT.py
     // check for uma enum max usage, since we're abusing
     // UMA_HISTOGRAM_ENUMERATION to report a discrete value.
     UMA_HISTOGRAM_ENUMERATION("Media.VideoColorRange",
                               stream->codec->color_range,
                               AVCOL_RANGE_NB);  // PRESUBMIT_IGNORE_UMA_MAX
   }
 
   VideoFrame::Format format = PixelFormatToVideoFormat(stream->codec->pix_fmt);
-  if (codec == kCodecVP9) {
-    // TODO(tomfinegan): libavcodec doesn't know about VP9.

[liberato (no reviews please), 2015/07/10 17:15:09]

maybe keep the TODO.

+  // The format and coded size may be unknown by FFmpeg for VP9, and on Android
+  // where FFmpeg is compiled without parsers.
+  if (format == VideoFrame::UNKNOWN)

[liberato (no reviews please), 2015/07/10 17:15:09]

setting any unknown format to YV12 seems like it could go pretty wrong.  could
mess up UMA stats if nothing else.

at least, it needs to be protected for the android case.  i'm a little surprised
that it's okay for VP9.  doesn't VP9 support alpha?

how much does this setting actually affect?  it looks like there are a fair
number of consumers.

[watk, 2015/07/10 18:51:26]

AFAIK this is ok, but I'm not sure enough, so I'll make it Android only. I think
the right longer term fix is to allow VideoDecoderConfigs to contain unknowns,
but that's a larger change which requires auditing the consumers.

     format = VideoFrame::YV12;
+  if (coded_size == gfx::Size(0, 0))

[liberato (no reviews please), 2015/07/10 17:15:09]

also seems scary to do for any unknown size.

[watk, 2015/07/10 18:51:25]

Done.

     coded_size = visible_rect.size();
-  }
 
   // Pad out |coded_size| for subsampled YUV formats.
   if (format != VideoFrame::YV24) {
     coded_size.set_width((coded_size.width() + 1) / 2 * 2);
     if (format != VideoFrame::YV16)
       coded_size.set_height((coded_size.height() + 1) / 2 * 2);
   }
 
   bool is_encrypted = false;
   AVDictionaryEntry* key = av_dict_get(stream->metadata, "enc_key_id", NULL, 0);
@@ skipping 173 matching lines @@
       return false;
 
     *out = parsed_time;
     return true;
   }
 
   return false;
 }
 
 }  // namespace media