src/api.cc - Issue 1230793002: [es6] silence access-check failure for well-known symbol properties

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api.cc

Issue 1230793002: [es6] silence access-check failure for well-known symbol properties (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Ensure @@isConcatSpreadable is actually installed now that its in a separate list Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/api.cc

diff --git a/src/api.cc b/src/api.cc

index 309bf3c50ec21bf0eec5cd2e0d587de511809006..5795e26837a9b02bafbd712cf2296a8ed6b5d90f 100644

--- a/src/api.cc

+++ b/src/api.cc

@@ -6792,6 +6792,12 @@ Local<Symbol> v8::Symbol::GetToStringTag(Isolate* isolate) {

}

+Local<Symbol> v8::Symbol::GetIsConcatSpreadable(Isolate* isolate) {

+ i::Isolate* i_isolate = reinterpret_cast<i::Isolate*>(isolate);

+ return Utils::ToLocal(i_isolate->factory()->is_concat_spreadable_symbol());

Local<Number> v8::Number::New(Isolate* isolate, double value) {

i::Isolate* internal_isolate = reinterpret_cast<i::Isolate*>(isolate);

if (std::isnan(value)) {

« no previous file with comments | « include/v8.h ('k') | src/bootstrapper.cc » ('j') | no next file with comments »