Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/objects-inl.h

Issue 1230793002: [es6] silence access-check failure for well-known symbol properties (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Ensure @@isConcatSpreadable is actually installed now that its in a separate list Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects.cc ('k') | src/profiler/heap-snapshot-generator.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 3702 matching lines...) Expand 10 before | Expand all | Expand 10 after
3713 return false; 3713 return false;
3714 } 3714 }
3715 return String::SlowEquals(Handle<String>::cast(one), 3715 return String::SlowEquals(Handle<String>::cast(one),
3716 Handle<String>::cast(two)); 3716 Handle<String>::cast(two));
3717 } 3717 }
3718 3718
3719 3719
3720 ACCESSORS(Symbol, name, Object, kNameOffset) 3720 ACCESSORS(Symbol, name, Object, kNameOffset)
3721 SMI_ACCESSORS(Symbol, flags, kFlagsOffset) 3721 SMI_ACCESSORS(Symbol, flags, kFlagsOffset)
3722 BOOL_ACCESSORS(Symbol, flags, is_private, kPrivateBit) 3722 BOOL_ACCESSORS(Symbol, flags, is_private, kPrivateBit)
3723 BOOL_ACCESSORS(Symbol, flags, is_well_known_symbol, kWellKnownSymbolBit)
3723 3724
3724 3725
3725 bool String::Equals(String* other) { 3726 bool String::Equals(String* other) {
3726 if (other == this) return true; 3727 if (other == this) return true;
3727 if (this->IsInternalizedString() && other->IsInternalizedString()) { 3728 if (this->IsInternalizedString() && other->IsInternalizedString()) {
3728 return false; 3729 return false;
3729 } 3730 }
3730 return SlowEquals(other); 3731 return SlowEquals(other);
3731 } 3732 }
3732 3733
(...skipping 4380 matching lines...) Expand 10 before | Expand all | Expand 10 after
8113 #undef WRITE_INT64_FIELD 8114 #undef WRITE_INT64_FIELD
8114 #undef READ_BYTE_FIELD 8115 #undef READ_BYTE_FIELD
8115 #undef WRITE_BYTE_FIELD 8116 #undef WRITE_BYTE_FIELD
8116 #undef NOBARRIER_READ_BYTE_FIELD 8117 #undef NOBARRIER_READ_BYTE_FIELD
8117 #undef NOBARRIER_WRITE_BYTE_FIELD 8118 #undef NOBARRIER_WRITE_BYTE_FIELD
8118 8119
8119 } // namespace internal 8120 } // namespace internal
8120 } // namespace v8 8121 } // namespace v8
8121 8122
8122 #endif // V8_OBJECTS_INL_H_ 8123 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | src/profiler/heap-snapshot-generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698