Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Side by Side Diff: src/objects-inl.h

Issue 1230793002: [es6] silence access-check failure for well-known symbol properties (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Make well-known symbols behave magically Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 3632 matching lines...) Expand 10 before | Expand all | Expand 10 after
3643 return false; 3643 return false;
3644 } 3644 }
3645 return String::SlowEquals(Handle<String>::cast(one), 3645 return String::SlowEquals(Handle<String>::cast(one),
3646 Handle<String>::cast(two)); 3646 Handle<String>::cast(two));
3647 } 3647 }
3648 3648
3649 3649
3650 ACCESSORS(Symbol, name, Object, kNameOffset) 3650 ACCESSORS(Symbol, name, Object, kNameOffset)
3651 SMI_ACCESSORS(Symbol, flags, kFlagsOffset) 3651 SMI_ACCESSORS(Symbol, flags, kFlagsOffset)
3652 BOOL_ACCESSORS(Symbol, flags, is_private, kPrivateBit) 3652 BOOL_ACCESSORS(Symbol, flags, is_private, kPrivateBit)
3653 BOOL_ACCESSORS(Symbol, flags, is_well_known_symbol, kWellKnownSymbolBit)
3653 3654
3654 3655
3655 bool String::Equals(String* other) { 3656 bool String::Equals(String* other) {
3656 if (other == this) return true; 3657 if (other == this) return true;
3657 if (this->IsInternalizedString() && other->IsInternalizedString()) { 3658 if (this->IsInternalizedString() && other->IsInternalizedString()) {
3658 return false; 3659 return false;
3659 } 3660 }
3660 return SlowEquals(other); 3661 return SlowEquals(other);
3661 } 3662 }
3662 3663
(...skipping 4380 matching lines...) Expand 10 before | Expand all | Expand 10 after
8043 #undef WRITE_INT64_FIELD 8044 #undef WRITE_INT64_FIELD
8044 #undef READ_BYTE_FIELD 8045 #undef READ_BYTE_FIELD
8045 #undef WRITE_BYTE_FIELD 8046 #undef WRITE_BYTE_FIELD
8046 #undef NOBARRIER_READ_BYTE_FIELD 8047 #undef NOBARRIER_READ_BYTE_FIELD
8047 #undef NOBARRIER_WRITE_BYTE_FIELD 8048 #undef NOBARRIER_WRITE_BYTE_FIELD
8048 8049
8049 } // namespace internal 8050 } // namespace internal
8050 } // namespace v8 8051 } // namespace v8
8051 8052
8052 #endif // V8_OBJECTS_INL_H_ 8053 #endif // V8_OBJECTS_INL_H_
OLDNEW
« src/objects.cc ('K') | « src/objects.cc ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698