Return --harmony-spread-arrays from enabled-by-default to staging

Unship spread calls and spread arrays

Return both --harmony-spreadcalls and --harmony-spread-arrays
to staging, in preparation for disabling those features on
the M45 branch.

There are no known bugs in spread calls, but without rest and spread
arrays it seems appropriate to leave all of them out rather than
only supporting a singular use of the '...' operator.

BUG=v8:4298
LOG=y

Committed: https://crrev.com/8735d38ed6cd44a5dae63047a3ed867f4c8769b6
Cr-Commit-Position: refs/heads/master@{#29657}

[adamk, 2015-07-14 01:54:33]

adamk@chromium.org changed reviewers:
+ rossberg@chromium.org

[caitp (gmail), 2015-07-14 03:24:01]

https://crrev.com/1237003002 possibly fixes the bug, but if it takes much longer
to verify the fix or address comments, i vote to just disable anyways

[rossberg, 2015-07-14 06:51:50]

LGTM

To maintain some symmetry, we should also unship spread calls (now that both
rest and spread arrays are gone). Can you include that in this CL?

Also, please retitle the CL to "Unship" for clarity.

[rossberg, 2015-07-14 06:53:35]

Also, make sure to ask mhablich to merge back this change.

[adamk, 2015-07-14 16:18:54]

Given that we have what looks like a small fix (after caitp's helpful pointer to
where my code was busted), do we not want to give a shot at merging a fix to
this on the branch? If we were happy with shipping this before this bug was
known, I don't know why we'd be less happy to try to ship it with this bug
fixed. Unless we just want to have a blanket policy of "if a flag can be flipped
to fix a bug on branch, always do that."

WDYT?

[rossberg, 2015-07-14 16:26:02]

On 2015/07/14 16:18:54, adamk wrote:
> Given that we have what looks like a small fix (after caitp's helpful pointer
to
> where my code was busted), do we not want to give a shot at merging a fix to
> this on the branch? If we were happy with shipping this before this bug was
> known, I don't know why we'd be less happy to try to ship it with this bug
> fixed. Unless we just want to have a blanket policy of "if a flag can be
flipped
> to fix a bug on branch, always do that."
> 
> WDYT?

I think it's too late. The features already got removed from the M45 blog post.
The fix would need some bake time. I rather don't want to cause more back &
forth. There is no rush, we can ship it in 46 (it actually makes a nice package
with destructuring).

[adamk, 2015-07-14 17:29:24]

On 2015/07/14 16:26:02, rossberg wrote:
> On 2015/07/14 16:18:54, adamk wrote:
> > Given that we have what looks like a small fix (after caitp's helpful
pointer
> to
> > where my code was busted), do we not want to give a shot at merging a fix to
> > this on the branch? If we were happy with shipping this before this bug was
> > known, I don't know why we'd be less happy to try to ship it with this bug
> > fixed. Unless we just want to have a blanket policy of "if a flag can be
> flipped
> > to fix a bug on branch, always do that."
> > 
> > WDYT?
> 
> I think it's too late. The features already got removed from the M45 blog
post.
> The fix would need some bake time. I rather don't want to cause more back &
> forth. There is no rush, we can ship it in 46 (it actually makes a nice
package
> with destructuring).

Not sure the blog post is sufficient reason, but I agree there's no hurry, so if
you're more comfortable with disabling in M45 I'm ok with that approach.

[adamk, 2015-07-14 17:34:39]

The CQ bit was checked by adamk@chromium.org

[adamk, 2015-07-14 17:34:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
rossberg@chromium.org
Link to the patchset: https://codereview.chromium.org/1230773005/#ps20001
(title: "Also disable spread-calls")

[commit-bot: I haz the power, 2015-07-14 17:35:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1230773005/20001

[commit-bot: I haz the power, 2015-07-14 18:40:31]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-07-14 18:40:46]

Patchset 2 (id:??) landed as
https://crrev.com/8735d38ed6cd44a5dae63047a3ed867f4c8769b6
Cr-Commit-Position: refs/heads/master@{#29657}