Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1041)

Unified Diff: platform_tools/android/bin/android_gdb_app

Issue 1230773003: Move android_gdb_tmp into out/ (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Move android_gdb_tmp into the out directory. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | platform_tools/android/bin/android_gdb_native » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: platform_tools/android/bin/android_gdb_app
diff --git a/platform_tools/android/bin/android_gdb_app b/platform_tools/android/bin/android_gdb_app
index 000d908005e6518f5b333bcc03e520ff3e6269e0..32e7adbc34ebf0427ce6f994e08b7c0e3a9b4c2b 100755
--- a/platform_tools/android/bin/android_gdb_app
+++ b/platform_tools/android/bin/android_gdb_app
@@ -26,7 +26,7 @@ else
fi
# We need the debug symbols from these files
-GDB_TMP_DIR=$(pwd)/android_gdb_tmp
+GDB_TMP_DIR=$(pwd)/out/android_gdb_tmp
djsollen 2015/07/10 16:10:38 this only puts in in out if you execute the script
scroggo 2015/07/10 17:21:04 FWIW, SKIA_OUT is set to /out/config/android-${TAR
scroggo 2015/07/10 17:21:27 Per device-type
mkdir -p $GDB_TMP_DIR
scroggo_chromium 2015/07/10 16:02:50 Has out/ already been created at this point? Or sh
djsollen 2015/07/10 16:10:38 I think you want to do -p to be safe
scroggo 2015/07/10 17:21:04 Ok good, we're already using -p.
echo "Copying symbol files"
adb_pull_if_needed /system/bin/app_process $GDB_TMP_DIR
« no previous file with comments | « no previous file | platform_tools/android/bin/android_gdb_native » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698