Move android_gdb_tmp into out/

Move android_gdb_tmp into out/

This way it will be ignored.

Committed: https://skia.googlesource.com/skia/+/33d35263bfb0571af2d7716e3873dc8aec3a0afb

[scroggo, 2015-07-10 15:47:25]

scroggo@google.com changed reviewers:
+ djsollen@google.com, scroggo@google.com

[scroggo, 2015-07-10 15:47:26]

https://codereview.chromium.org/1230773003/diff/1/.gitignore
File .gitignore (right):

https://codereview.chromium.org/1230773003/diff/1/.gitignore#newcode11
.gitignore:11: android_gdb_tmp
Alternatively, should this go somewhere else? (e.g. inside out? Or does it make
sense to keep this separate?)

[djsollen, 2015-07-10 15:48:44]

I like the idea of putting it into the out directory!

[scroggo_chromium, 2015-07-10 16:02:50]

On 2015/07/10 15:48:44, djsollen wrote:
> I like the idea of putting it into the out directory!

Done!

https://codereview.chromium.org/1230773003/diff/20001/platform_tools/android/...
File platform_tools/android/bin/android_gdb_app (right):

https://codereview.chromium.org/1230773003/diff/20001/platform_tools/android/...
platform_tools/android/bin/android_gdb_app:30: mkdir -p $GDB_TMP_DIR
Has out/ already been created at this point? Or should we call the recursive
version?

[djsollen, 2015-07-10 16:10:38]

https://codereview.chromium.org/1230773003/diff/20001/platform_tools/android/...
File platform_tools/android/bin/android_gdb_app (right):

https://codereview.chromium.org/1230773003/diff/20001/platform_tools/android/...
platform_tools/android/bin/android_gdb_app:29:
GDB_TMP_DIR=$(pwd)/out/android_gdb_tmp
this only puts in in out if you execute the script from the root of the skia
project.

I think this should be $SKIA_OUT which gets defined in android_setup.sh

https://codereview.chromium.org/1230773003/diff/20001/platform_tools/android/...
platform_tools/android/bin/android_gdb_app:30: mkdir -p $GDB_TMP_DIR
On 2015/07/10 16:02:50, scroggo_chromium wrote:
> Has out/ already been created at this point? Or should we call the recursive
> version?

I think you want to do -p to be safe

[scroggo, 2015-07-10 17:21:05]

https://codereview.chromium.org/1230773003/diff/20001/platform_tools/android/...
File platform_tools/android/bin/android_gdb_app (right):

https://codereview.chromium.org/1230773003/diff/20001/platform_tools/android/...
platform_tools/android/bin/android_gdb_app:29:
GDB_TMP_DIR=$(pwd)/out/android_gdb_tmp
On 2015/07/10 16:10:38, djsollen wrote:
> this only puts in in out if you execute the script from the root of the skia
> project.
> 
> I think this should be $SKIA_OUT which gets defined in android_setup.sh

FWIW, SKIA_OUT is set to /out/config/android-${TARGET_DEVICE}. That folder is
fine with me if it is with you. It does make a slight difference though - the
symbols are now per device. Maybe that is okay/desirable?

https://codereview.chromium.org/1230773003/diff/20001/platform_tools/android/...
platform_tools/android/bin/android_gdb_app:30: mkdir -p $GDB_TMP_DIR
On 2015/07/10 16:10:38, djsollen wrote:
> On 2015/07/10 16:02:50, scroggo_chromium wrote:
> > Has out/ already been created at this point? Or should we call the recursive
> > version?
> 
> I think you want to do -p to be safe

Ok good, we're already using -p.

[scroggo, 2015-07-10 17:21:28]

https://codereview.chromium.org/1230773003/diff/20001/platform_tools/android/...
File platform_tools/android/bin/android_gdb_app (right):

https://codereview.chromium.org/1230773003/diff/20001/platform_tools/android/...
platform_tools/android/bin/android_gdb_app:29:
GDB_TMP_DIR=$(pwd)/out/android_gdb_tmp
On 2015/07/10 17:21:04, scroggo wrote:
> On 2015/07/10 16:10:38, djsollen wrote:
> > this only puts in in out if you execute the script from the root of the skia
> > project.
> > 
> > I think this should be $SKIA_OUT which gets defined in android_setup.sh
> 
> FWIW, SKIA_OUT is set to /out/config/android-${TARGET_DEVICE}. That folder is
> fine with me if it is with you. It does make a slight difference though - the
> symbols are now per device. Maybe that is okay/desirable?

Per device-type

[djsollen, 2015-07-10 17:45:46]

lgtm

[scroggo, 2015-07-10 17:57:21]

The CQ bit was checked by scroggo@google.com

[commit-bot: I haz the power, 2015-07-10 17:57:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1230773003/40001

[commit-bot: I haz the power, 2015-07-10 18:05:13]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/33d35263bfb0571af2d7716e3873dc8aec3a0afb