Issue 1230763007: Make CJBig2_Object::operator delete accept nullptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1230763007: Make CJBig2_Object::operator delete accept nullptr (Closed)

Created:
5 years, 5 months ago by Vitaly Buka (NO REVIEWS)

Modified:
5 years, 5 months ago

Reviewers:
Lei Zhang, jam

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Make CJBig2_Object::operator delete accept nullptr Standard delete operator should do noting for nullptr. Overloaded CJBig2_Object::operator delete de-referenced provided pointer causing crashes after https://codereview.chromium.org/1192743004/ TBR=thestig BUG=508197 Committed: https://pdfium.googlesource.com/pdfium/+/aa575d4805bf7a9e83f00b56e38d4de39d90f95c

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
	M	core/src/fxcodec/jbig2/JBig2_Object.cpp	View		3 chunks	+7 lines, -3 lines	0 comments	Download

Total messages: 3 (1 generated)

Vitaly Buka (NO REVIEWS)

Committed patchset #1 (id:1) manually as aa575d4805bf7a9e83f00b56e38d4de39d90f95c (presubmit successful).

5 years, 5 months ago (2015-07-10 22:41:04 UTC) #2

Message was sent while issue was closed.

lgtm