[Interpreter] Add BytecodeArray class and add to SharedFunctionInfo.

src/objects-printer.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #include "src/disasm.h"
 #include "src/disassembler.h"
 #include "src/heap/objects-visiting.h"
+#include "src/interpreter/bytecodes.h"
 #include "src/jsregexp.h"
 #include "src/ostreams.h"
 
 namespace v8 {
 namespace internal {
 
 #ifdef OBJECT_PRINT
 
 void Object::Print() {
   OFStream os(stdout);
@@ skipping 45 matching lines @@
       break;
     case FIXED_DOUBLE_ARRAY_TYPE:
       FixedDoubleArray::cast(this)->FixedDoubleArrayPrint(os);
       break;
     case FIXED_ARRAY_TYPE:
       FixedArray::cast(this)->FixedArrayPrint(os);
       break;
     case BYTE_ARRAY_TYPE:
       ByteArray::cast(this)->ByteArrayPrint(os);
       break;
+    case BYTECODE_ARRAY_TYPE:
+      BytecodeArray::cast(this)->BytecodeArrayPrint(os);
+      break;
     case FREE_SPACE_TYPE:
       FreeSpace::cast(this)->FreeSpacePrint(os);
       break;
 
 #define PRINT_EXTERNAL_ARRAY(Type, type, TYPE, ctype, size)            \
   case EXTERNAL_##TYPE##_ARRAY_TYPE:                                   \
     External##Type##Array::cast(this)->External##Type##ArrayPrint(os); \
     break;
 
      TYPED_ARRAYS(PRINT_EXTERNAL_ARRAY)
@@ skipping 109 matching lines @@
       break;
   }
 }
 
 
 void ByteArray::ByteArrayPrint(std::ostream& os) {  // NOLINT
   os << "byte array, data starts at " << GetDataStartAddress();
 }
 
 
+void BytecodeArray::BytecodeArrayPrint(std::ostream& os) {  // NOLINT
+  os << "bytecode array, data starts at " << GetDataStartAddress();
+  for (int i = 0; i < this->length(); i++) {
+    byte bc = this->get(i);
+    os << "\n" << i << " : " << this->get(i) << " "
+       << static_cast<interpreter::Bytecode>(bc);

[rmcilroy, 2015/07/15 13:33:38]

How about we move this to a BytecodeArray::Dissassemble() function so it can be
used from elsewhere if necessary.

[oth, 2015/07/16 09:15:50]

Done.

+  }
+}
+
+
 void FreeSpace::FreeSpacePrint(std::ostream& os) {  // NOLINT
   os << "free space, size " << Size();
 }
 
 
 #define EXTERNAL_ARRAY_PRINTER(Type, type, TYPE, ctype, size)                \
   void External##Type##Array::External##Type##ArrayPrint(std::ostream& os) { \
     os << "external " #type " array";                                        \
   }
 
@@ skipping 545 matching lines @@
   // script()->Print(os);
   os << "\n - function token position = " << function_token_position();
   os << "\n - start position = " << start_position();
   os << "\n - end position = " << end_position();
   os << "\n - is expression = " << is_expression();
   os << "\n - debug info = " << Brief(debug_info());
   os << "\n - length = " << length();
   os << "\n - optimized_code_map = " << Brief(optimized_code_map());
   os << "\n - feedback_vector = ";
   feedback_vector()->FixedArrayPrint(os);
+  // TODO(oth): implement real bytecode printer

[rmcilroy, 2015/07/15 13:33:38]

Actually I think emitting the pointer here is fine for the ShareFunctionInfo
object. I would remove the TODO. (someone can always call BytecodeArrayPrint on
the pointer to get the bytecode pretty-printed.

[oth, 2015/07/16 09:15:50]

Done.

+  os << "\n - bytecode_array = " << bytecode_array();
   os << "\n";
 }
 
 
 void JSGlobalProxy::JSGlobalProxyPrint(std::ostream& os) {  // NOLINT
   os << "global_proxy ";
   JSObjectPrint(os);
   os << "native context : " << Brief(native_context());
   os << "\n";
 }
@@ skipping 394 matching lines @@
   }
 }
 
 
 void JSObject::PrintTransitions(std::ostream& os) {  // NOLINT
   TransitionArray::PrintTransitions(os, map()->raw_transitions());
 }
 #endif  // defined(DEBUG) || defined(OBJECT_PRINT)
 }  // namespace internal
 }  // namespace v8