[Interpreter] Add BytecodeArray class and add to SharedFunctionInfo.

src/objects-debug.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #include "src/disasm.h"
 #include "src/disassembler.h"
 #include "src/heap/objects-visiting.h"
 #include "src/jsregexp.h"
@@ skipping 52 matching lines @@
       break;
     case FIXED_ARRAY_TYPE:
       FixedArray::cast(this)->FixedArrayVerify();
       break;
     case FIXED_DOUBLE_ARRAY_TYPE:
       FixedDoubleArray::cast(this)->FixedDoubleArrayVerify();
       break;
     case BYTE_ARRAY_TYPE:
       ByteArray::cast(this)->ByteArrayVerify();
       break;
+    case BYTECODE_ARRAY_TYPE:
+      BytecodeArray::cast(this)->BytecodeArrayVerify();
+      break;
     case FREE_SPACE_TYPE:
       FreeSpace::cast(this)->FreeSpaceVerify();
       break;
 
 #define VERIFY_TYPED_ARRAY(Type, type, TYPE, ctype, size)                      \
     case EXTERNAL_##TYPE##_ARRAY_TYPE:                                         \
       External##Type##Array::cast(this)->External##Type##ArrayVerify();        \
       break;                                                                   \
     case FIXED_##TYPE##_ARRAY_TYPE:                                            \
       Fixed##Type##Array::cast(this)->FixedTypedArrayVerify();                 \
@@ skipping 132 matching lines @@
 
 
 void Float32x4::Float32x4Verify() { CHECK(IsFloat32x4()); }
 
 
 void ByteArray::ByteArrayVerify() {
   CHECK(IsByteArray());
 }
 
 
+void BytecodeArray::BytecodeArrayVerify() {
+  // TODO(oth): Walk bytecodes and immediate values to validate sanity.
+  CHECK(IsBytecodeArray());
+}
+
+
 void FreeSpace::FreeSpaceVerify() {
   CHECK(IsFreeSpace());
 }
 
 
 #define EXTERNAL_ARRAY_VERIFY(Type, type, TYPE, ctype, size)                  \
   void External##Type##Array::External##Type##ArrayVerify() {                 \
     CHECK(IsExternal##Type##Array());                                         \
   }
 
@@ skipping 298 matching lines @@
 
 
 void SharedFunctionInfo::SharedFunctionInfoVerify() {
   CHECK(IsSharedFunctionInfo());
   VerifyObjectField(kNameOffset);
   VerifyObjectField(kCodeOffset);
   VerifyObjectField(kOptimizedCodeMapOffset);
   VerifyObjectField(kFeedbackVectorOffset);
   VerifyObjectField(kScopeInfoOffset);
   VerifyObjectField(kInstanceClassNameOffset);
   VerifyObjectField(kFunctionDataOffset);

[rmcilroy, 2015/07/22 07:44:00]

Could you add a CHECK here that kFunctionDataOffset is either a
FunctionTemplateInfo, a Smi, a BytecodeArray or Undefined.

[oth, 2015/07/22 08:50:00]

Done. And added call to verify Smi/BytecodeArray.

   VerifyObjectField(kScriptOffset);
   VerifyObjectField(kDebugInfoOffset);
 }
 
 
 void JSGlobalProxy::JSGlobalProxyVerify() {
   CHECK(IsJSGlobalProxy());
   JSObjectVerify();
   VerifyObjectField(JSGlobalProxy::kNativeContextOffset);
   // Make sure that this object has no properties, elements.
@@ skipping 718 matching lines @@
                          : it.rinfo()->target_object();
     CHECK(!CanLeak(target, heap, skip_weak_cell));
   }
 }
 
 
 #endif  // DEBUG
 
 }  // namespace internal
 }  // namespace v8