Issue 1230733002: Fix test failures from b9e2a7fd2bb21933c4dd23354a35a2d83bdc3be8

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1230733002: Fix test failures from b9e2a7fd2bb21933c4dd23354a35a2d83bdc3be8 (Closed)

Created:
5 years, 5 months ago by abarth-chromium

Modified:
5 years, 5 months ago

Reviewers:
Hixie

CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Fix test failures from b9e2a7fd2bb21933c4dd23354a35a2d83bdc3be8 We need to test for visual overflow after writing size because we need to use the up-to-date value of size. TBR=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/10bec38f707b9e609f8fef886ab3fe56ee5455f7

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	sky/sdk/lib/rendering/block.dart	View		3 chunks	+5 lines, -5 lines	0 comments	Download

Total messages: 3 (0 generated)

abarth-chromium

Committed patchset #1 (id:1) manually as 10bec38f707b9e609f8fef886ab3fe56ee5455f7 (presubmit successful).

5 years, 5 months ago (2015-07-09 03:34:25 UTC) #2

Message was sent while issue was closed.

lgtm