Move CycleDirection enum into shelf_constants.

Move CycleDirection enum into shelf_constants.

I decided to move it there, because enum really defines 'constants'.

I'm considering moving the remaining of launcher_types.h into a new file
called shelf_item.h, since the types there are really related/tied to
ShelfItem.

BUG=248353
TEST=None, no functional changes
R=jamescook@chromium.org,harrym@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243247

[tfarina, 2014-01-01 19:25:43]

https://codereview.chromium.org/123073002/diff/1/ash/shelf/shelf.h
File ash/shelf/shelf.h (right):

https://codereview.chromium.org/123073002/diff/1/ash/shelf/shelf.h#newcode10
ash/shelf/shelf.h:10: #include "ash/shelf/shelf_types.h"
do you prefer that I move it into shelf_types.h?

[James Cook, 2014-01-06 17:25:38]

LGTM. Moving launcher_types.h to shelf_item.h or shelf_item_types.h makes sense
to me too.

[commit-bot: I haz the power, 2014-01-06 17:58:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/123073002/1

[commit-bot: I haz the power, 2014-01-06 20:43:49]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2014-01-06 23:18:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/123073002/1

[commit-bot: I haz the power, 2014-01-07 10:48:08]

Change committed as 243247