Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 1230703005: make path-reverse gm portable (Closed)

Created:
5 years, 5 months ago by caryclark
Modified:
5 years, 5 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

make path-reverse gm portable Put font glyph data in test as path instead of getting data from the Mac font. THe font may change, and is not available on most platforms. Also remove unreachable code. R=reed@google.com Committed: https://skia.googlesource.com/skia/+/cae3ca65d2b3ae8c8c878ec860ea0620231af81a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -34 lines) Patch
M gm/pathreverse.cpp View 4 chunks +38 lines, -34 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1230703005/1
5 years, 5 months ago (2015-07-15 15:41:02 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 5 months ago (2015-07-15 15:41:03 UTC) #3
reed1
lgtm
5 years, 5 months ago (2015-07-15 15:43:39 UTC) #4
commit-bot: I haz the power
5 years, 5 months ago (2015-07-15 15:58:15 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/cae3ca65d2b3ae8c8c878ec860ea0620231af81a

Powered by Google App Engine
This is Rietveld 408576698