Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 1230653005: Change Native Client x86 usr include and link path to match SDK expectations (Closed)

Created:
5 years, 5 months ago by Derek Schuff
Modified:
5 years, 5 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-clang.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Change Native Client x86 usr include and link path to match SDK expectations GNU multilib style uses x86_64-nacl/include and x86_64-nacl/usr/include but the SDK expects i686-nacl/usr/include for its files. Change the driver to use this. This is a cherrypick/rebase of http://reviews.llvm.org/D11271 because upstream has MIPS changes that have not been picked. BUG= https://code.google.com/p/nativeclient/issues/detail?id=4108 R=jvoung@chromium.org Committed: 78af27d21c1236a6d132106ad9e0bfdb6d0bd8cd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -9 lines) Patch
M lib/Driver/ToolChains.cpp View 2 chunks +22 lines, -6 lines 0 comments Download
M test/Driver/nacl-direct.c View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Derek Schuff
5 years, 5 months ago (2015-07-16 21:22:08 UTC) #2
jvoung (off chromium)
lgtm
5 years, 5 months ago (2015-07-16 21:53:21 UTC) #3
Derek Schuff
5 years, 5 months ago (2015-07-16 22:05:06 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
78af27d21c1236a6d132106ad9e0bfdb6d0bd8cd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698