Issue 1230653005: Change Native Client x86 usr include and link path to match SDK expectations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1230653005: Change Native Client x86 usr include and link path to match SDK expectations (Closed)

Created:
5 years, 5 months ago by Derek Schuff

Modified:
5 years, 5 months ago

Reviewers:
jvoung (off chromium)

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-clang.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Change Native Client x86 usr include and link path to match SDK expectations GNU multilib style uses x86_64-nacl/include and x86_64-nacl/usr/include but the SDK expects i686-nacl/usr/include for its files. Change the driver to use this. This is a cherrypick/rebase of http://reviews.llvm.org/D11271 because upstream has MIPS changes that have not been picked. BUG= https://code.google.com/p/nativeclient/issues/detail?id=4108 R=jvoung@chromium.org Committed: 78af27d21c1236a6d132106ad9e0bfdb6d0bd8cd

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -9 lines)			Patch
	M	lib/Driver/ToolChains.cpp	View		2 chunks	+22 lines, -6 lines	0 comments	Download
	M	test/Driver/nacl-direct.c	View		3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Derek Schuff

5 years, 5 months ago (2015-07-16 22:05:06 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
78af27d21c1236a6d132106ad9e0bfdb6d0bd8cd (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages