src/mips/lithium-codegen-mips.cc - Issue 1230653004: Allow deferred handle dereference in EmitLoadRegister to retrieve number.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/mips/lithium-codegen-mips.cc

Issue 1230653004: Allow deferred handle dereference in EmitLoadRegister to retrieve number. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/mips/lithium-codegen-mips.cc

diff --git a/src/mips/lithium-codegen-mips.cc b/src/mips/lithium-codegen-mips.cc

index 5c26001ef0feb9b64d6e454567908f6c353e2b6f..b1166c7c647bbc10c5f7897c43e0df668e281d3a 100644

--- a/src/mips/lithium-codegen-mips.cc

+++ b/src/mips/lithium-codegen-mips.cc

@@ -424,6 +424,7 @@ Register LCodeGen::EmitLoadRegister(LOperand* op, Register scratch) {

Handle<Object> literal = constant->handle(isolate());

Representation r = chunk_->LookupLiteralRepresentation(const_op);

if (r.IsInteger32()) {

+ AllowDeferredHandleDereference get_number;

DCHECK(literal->IsNumber());

__ li(scratch, Operand(static_cast<int32_t>(literal->Number())));

} else if (r.IsSmi()) {

« no previous file with comments | « src/arm/lithium-codegen-arm.cc ('k') | src/mips64/lithium-codegen-mips64.cc » ('j') | no next file with comments »