Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1230643006: Update inclusion of GraphicsContextStateSaver.h (Closed)

Created:
5 years, 5 months ago by fs
Modified:
5 years, 5 months ago
CC:
blink-reviews, szager+layoutwatch_chromium.org, dshwang, eae+blinkwatch, rwlbuis, krit, drott+blinkwatch_chromium.org, blink-reviews-html_chromium.org, Justin Novosad, danakj, dglazkov+blink, Rik, jchaffraix+rendering, blink-reviews-paint_chromium.org, zoltan1, jbroman, pdr+graphicswatchlist_chromium.org, blink-reviews-rendering, pdr+renderingwatchlist_chromium.org, leviw+renderwatch, slimming-paint-reviews_chromium.org, f(malita), Stephen Chennney
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Update inclusion of GraphicsContextStateSaver.h Not needed in a bunch of places due to other refactoring work. Pushed down from PaintInfo.h into a number of places. Opportunity targets were fired upon. With this it's only being included in core/paint/ and platform/. BUG=424655 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198615

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -22 lines) Patch
M Source/core/frame/FrameView.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLCanvasElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/layout/LayoutBoxModelObject.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/layout/LayoutFieldset.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/layout/LayoutFileUploadControl.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/layout/LayoutTableCell.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/layout/line/InlineFlowBox.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/paint/DeprecatedPaintLayerScrollableArea.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/paint/FieldsetPainter.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/paint/InlineTextBoxPainter.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/paint/ObjectPainter.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/paint/PaintInfo.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/paint/SVGInlineTextBoxPainter.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/paint/SVGShapePainter.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/paint/TableCellPainter.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/graphics/BitmapImage.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/graphics/CrossfadeGeneratedImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/GeneratedImage.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/graphics/GradientGeneratedImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/Image.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/scroll/ScrollbarThemeMacCommon.mm View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
fs
5 years, 5 months ago (2015-07-09 15:02:19 UTC) #2
Stephen Chennney
lgtm, assuming it builds everywhere.
5 years, 5 months ago (2015-07-09 15:06:50 UTC) #3
fs
On 2015/07/09 15:06:50, Stephen Chenney wrote: > lgtm, assuming it builds everywhere. I was a ...
5 years, 5 months ago (2015-07-09 15:23:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1230643006/1
5 years, 5 months ago (2015-07-09 16:05:56 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-09 16:10:01 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198615

Powered by Google App Engine
This is Rietveld 408576698