Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Side by Side Diff: media/mojo/services/media_type_converters.cc

Issue 1230593005: Reland: Change the video color space default. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: big rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « media/mojo/interfaces/media_types.mojom ('k') | media/test/data/blackwhite_yuv420p_rec709.mp4 » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/mojo/services/media_type_converters.h" 5 #include "media/mojo/services/media_type_converters.h"
6 6
7 #include "media/base/audio_decoder_config.h" 7 #include "media/base/audio_decoder_config.h"
8 #include "media/base/buffering_state.h" 8 #include "media/base/buffering_state.h"
9 #include "media/base/cdm_config.h" 9 #include "media/base/cdm_config.h"
10 #include "media/base/cdm_key_information.h" 10 #include "media/base/cdm_key_information.h"
(...skipping 124 matching lines...) Expand 10 before | Expand all | Expand 10 after
135 ASSERT_ENUM_EQ_RAW(VideoPixelFormat, PIXEL_FORMAT_YV16, VIDEO_FORMAT_YV16); 135 ASSERT_ENUM_EQ_RAW(VideoPixelFormat, PIXEL_FORMAT_YV16, VIDEO_FORMAT_YV16);
136 ASSERT_ENUM_EQ_RAW(VideoPixelFormat, PIXEL_FORMAT_YV12A, VIDEO_FORMAT_YV12A); 136 ASSERT_ENUM_EQ_RAW(VideoPixelFormat, PIXEL_FORMAT_YV12A, VIDEO_FORMAT_YV12A);
137 ASSERT_ENUM_EQ_RAW(VideoPixelFormat, PIXEL_FORMAT_YV24, VIDEO_FORMAT_YV24); 137 ASSERT_ENUM_EQ_RAW(VideoPixelFormat, PIXEL_FORMAT_YV24, VIDEO_FORMAT_YV24);
138 #if defined(OS_MACOSX) 138 #if defined(OS_MACOSX)
139 ASSERT_ENUM_EQ_RAW(VideoPixelFormat, PIXEL_FORMAT_NV12, VIDEO_FORMAT_NV12); 139 ASSERT_ENUM_EQ_RAW(VideoPixelFormat, PIXEL_FORMAT_NV12, VIDEO_FORMAT_NV12);
140 #endif 140 #endif
141 ASSERT_ENUM_EQ_RAW(VideoPixelFormat, PIXEL_FORMAT_ARGB, VIDEO_FORMAT_ARGB); 141 ASSERT_ENUM_EQ_RAW(VideoPixelFormat, PIXEL_FORMAT_ARGB, VIDEO_FORMAT_ARGB);
142 ASSERT_ENUM_EQ_RAW(VideoPixelFormat, PIXEL_FORMAT_XRGB, VIDEO_FORMAT_XRGB); 142 ASSERT_ENUM_EQ_RAW(VideoPixelFormat, PIXEL_FORMAT_XRGB, VIDEO_FORMAT_XRGB);
143 ASSERT_ENUM_EQ_RAW(VideoPixelFormat, PIXEL_FORMAT_MAX, VIDEO_FORMAT_FORMAT_MAX); 143 ASSERT_ENUM_EQ_RAW(VideoPixelFormat, PIXEL_FORMAT_MAX, VIDEO_FORMAT_FORMAT_MAX);
144 144
145 // ColorSpace.
146 ASSERT_ENUM_EQ_RAW(ColorSpace,
147 COLOR_SPACE_UNSPECIFIED,
148 COLOR_SPACE_UNSPECIFIED);
149 ASSERT_ENUM_EQ_RAW(ColorSpace, COLOR_SPACE_JPEG, COLOR_SPACE_JPEG);
150 ASSERT_ENUM_EQ_RAW(ColorSpace, COLOR_SPACE_HD_REC709, COLOR_SPACE_HD_REC709);
151 ASSERT_ENUM_EQ_RAW(ColorSpace, COLOR_SPACE_SD_REC601, COLOR_SPACE_SD_REC601);
152 ASSERT_ENUM_EQ_RAW(ColorSpace, COLOR_SPACE_MAX, COLOR_SPACE_MAX);
153
145 // VideoCodec 154 // VideoCodec
146 ASSERT_ENUM_EQ_RAW(VideoCodec, kUnknownVideoCodec, VIDEO_CODEC_UNKNOWN); 155 ASSERT_ENUM_EQ_RAW(VideoCodec, kUnknownVideoCodec, VIDEO_CODEC_UNKNOWN);
147 ASSERT_ENUM_EQ(VideoCodec, kCodec, VIDEO_CODEC_, H264); 156 ASSERT_ENUM_EQ(VideoCodec, kCodec, VIDEO_CODEC_, H264);
148 ASSERT_ENUM_EQ(VideoCodec, kCodec, VIDEO_CODEC_, VC1); 157 ASSERT_ENUM_EQ(VideoCodec, kCodec, VIDEO_CODEC_, VC1);
149 ASSERT_ENUM_EQ(VideoCodec, kCodec, VIDEO_CODEC_, MPEG2); 158 ASSERT_ENUM_EQ(VideoCodec, kCodec, VIDEO_CODEC_, MPEG2);
150 ASSERT_ENUM_EQ(VideoCodec, kCodec, VIDEO_CODEC_, MPEG4); 159 ASSERT_ENUM_EQ(VideoCodec, kCodec, VIDEO_CODEC_, MPEG4);
151 ASSERT_ENUM_EQ(VideoCodec, kCodec, VIDEO_CODEC_, Theora); 160 ASSERT_ENUM_EQ(VideoCodec, kCodec, VIDEO_CODEC_, Theora);
152 ASSERT_ENUM_EQ(VideoCodec, kCodec, VIDEO_CODEC_, VP8); 161 ASSERT_ENUM_EQ(VideoCodec, kCodec, VIDEO_CODEC_, VP8);
153 ASSERT_ENUM_EQ(VideoCodec, kCodec, VIDEO_CODEC_, VP9); 162 ASSERT_ENUM_EQ(VideoCodec, kCodec, VIDEO_CODEC_, VP9);
154 ASSERT_ENUM_EQ_RAW(VideoCodec, kVideoCodecMax, VIDEO_CODEC_Max); 163 ASSERT_ENUM_EQ_RAW(VideoCodec, kVideoCodecMax, VIDEO_CODEC_Max);
(...skipping 263 matching lines...) Expand 10 before | Expand all | Expand 10 after
418 } 427 }
419 428
420 // static 429 // static
421 VideoDecoderConfigPtr 430 VideoDecoderConfigPtr
422 TypeConverter<VideoDecoderConfigPtr, media::VideoDecoderConfig>::Convert( 431 TypeConverter<VideoDecoderConfigPtr, media::VideoDecoderConfig>::Convert(
423 const media::VideoDecoderConfig& input) { 432 const media::VideoDecoderConfig& input) {
424 VideoDecoderConfigPtr config(VideoDecoderConfig::New()); 433 VideoDecoderConfigPtr config(VideoDecoderConfig::New());
425 config->codec = static_cast<VideoCodec>(input.codec()); 434 config->codec = static_cast<VideoCodec>(input.codec());
426 config->profile = static_cast<VideoCodecProfile>(input.profile()); 435 config->profile = static_cast<VideoCodecProfile>(input.profile());
427 config->format = static_cast<VideoFormat>(input.format()); 436 config->format = static_cast<VideoFormat>(input.format());
437 config->color_space = static_cast<ColorSpace>(input.color_space());
428 config->coded_size = Size::From(input.coded_size()); 438 config->coded_size = Size::From(input.coded_size());
429 config->visible_rect = Rect::From(input.visible_rect()); 439 config->visible_rect = Rect::From(input.visible_rect());
430 config->natural_size = Size::From(input.natural_size()); 440 config->natural_size = Size::From(input.natural_size());
431 if (input.extra_data()) { 441 if (input.extra_data()) {
432 std::vector<uint8_t> data(input.extra_data(), 442 std::vector<uint8_t> data(input.extra_data(),
433 input.extra_data() + input.extra_data_size()); 443 input.extra_data() + input.extra_data_size());
434 config->extra_data.Swap(&data); 444 config->extra_data.Swap(&data);
435 } 445 }
436 config->is_encrypted = input.is_encrypted(); 446 config->is_encrypted = input.is_encrypted();
437 return config.Pass(); 447 return config.Pass();
438 } 448 }
439 449
440 // static 450 // static
441 media::VideoDecoderConfig 451 media::VideoDecoderConfig
442 TypeConverter<media::VideoDecoderConfig, VideoDecoderConfigPtr>::Convert( 452 TypeConverter<media::VideoDecoderConfig, VideoDecoderConfigPtr>::Convert(
443 const VideoDecoderConfigPtr& input) { 453 const VideoDecoderConfigPtr& input) {
444 media::VideoDecoderConfig config; 454 media::VideoDecoderConfig config;
445 config.Initialize( 455 config.Initialize(
446 static_cast<media::VideoCodec>(input->codec), 456 static_cast<media::VideoCodec>(input->codec),
447 static_cast<media::VideoCodecProfile>(input->profile), 457 static_cast<media::VideoCodecProfile>(input->profile),
448 static_cast<media::VideoPixelFormat>(input->format), 458 static_cast<media::VideoPixelFormat>(input->format),
449 media::COLOR_SPACE_UNSPECIFIED, input->coded_size.To<gfx::Size>(), 459 static_cast<media::ColorSpace>(input->color_space),
450 input->visible_rect.To<gfx::Rect>(), input->natural_size.To<gfx::Size>(), 460 input->coded_size.To<gfx::Size>(), input->visible_rect.To<gfx::Rect>(),
461 input->natural_size.To<gfx::Size>(),
451 input->extra_data.size() ? &input->extra_data.front() : NULL, 462 input->extra_data.size() ? &input->extra_data.front() : NULL,
452 input->extra_data.size(), input->is_encrypted, false); 463 input->extra_data.size(), input->is_encrypted, false);
453 return config; 464 return config;
454 } 465 }
455 466
456 // static 467 // static
457 CdmKeyInformationPtr 468 CdmKeyInformationPtr
458 TypeConverter<CdmKeyInformationPtr, media::CdmKeyInformation>::Convert( 469 TypeConverter<CdmKeyInformationPtr, media::CdmKeyInformation>::Convert(
459 const media::CdmKeyInformation& input) { 470 const media::CdmKeyInformation& input) {
460 CdmKeyInformationPtr info(CdmKeyInformation::New()); 471 CdmKeyInformationPtr info(CdmKeyInformation::New());
(...skipping 30 matching lines...) Expand all
491 media::CdmConfig TypeConverter<media::CdmConfig, CdmConfigPtr>::Convert( 502 media::CdmConfig TypeConverter<media::CdmConfig, CdmConfigPtr>::Convert(
492 const CdmConfigPtr& input) { 503 const CdmConfigPtr& input) {
493 media::CdmConfig config; 504 media::CdmConfig config;
494 config.allow_distinctive_identifier = input->allow_distinctive_identifier; 505 config.allow_distinctive_identifier = input->allow_distinctive_identifier;
495 config.allow_persistent_state = input->allow_persistent_state; 506 config.allow_persistent_state = input->allow_persistent_state;
496 config.use_hw_secure_codecs = input->use_hw_secure_codecs; 507 config.use_hw_secure_codecs = input->use_hw_secure_codecs;
497 return config; 508 return config;
498 } 509 }
499 510
500 } // namespace mojo 511 } // namespace mojo
OLDNEW
« no previous file with comments | « media/mojo/interfaces/media_types.mojom ('k') | media/test/data/blackwhite_yuv420p_rec709.mp4 » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698