|
Reland: Change the video color space default.
Reverted by: e735fb0c4b13b72561b8f9931a8788e97deced33
Original CL: https://codereview.chromium.org/1228843003
The new change is to media/cast/sender/h264_vt_encoder_unittest.cc.
The rest of the changes are due to rebasing on top of
11edd34b171b78462c1a27ac6587d977833122ea, which moves the color space
enum.
Previously video without color space metadata was assumed to be in
Rec601. Now the default depends on the kind of playback. Normal src=
defaults to Rec601 for SD sized video (<720 pixels high), and Rec709 for
HD. MSE will always default to Rec709. Using a size based heuristic
doesn't make sense for MSE where it is common for the resolution to
change mid playback.
This CL doesn't change the meaning of COLOR_SPACE_UNSPECIFIED. Instead,
it adds a color space field to VideoDecoderConfig, and updates the video
decoders to use this as the default if they don't find a more
authoritative value in the bitstream.
This also fixes a (year old!) bug causing the blackwhite
tests to always succeed, renames the rec709 blackwhite test
file to match the name in blackwhite.html, and re-encodes it
to contain the color space metadata (previously it had none).
BUG= 333619
Committed: https://crrev.com/7cb4525761b68e41671af9006920d568be3c5405
Cr-Commit-Position: refs/heads/master@{#338607}
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+149 lines, -103 lines) |
Patch |
|
M |
chromecast/common/media/cma_param_traits.cc
|
View
|
1
|
2 chunks |
+5 lines, -3 lines |
0 comments
|
Download
|
|
M |
chromecast/common/media/cma_param_traits_macros.h
|
View
|
1
|
2 chunks |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
chromecast/media/cma/ipc_streamer/video_decoder_config_marshaller.cc
|
View
|
1
|
5 chunks |
+6 lines, -1 line |
0 comments
|
Download
|
|
M |
chromecast/media/cma/pipeline/audio_video_pipeline_impl_unittest.cc
|
View
|
1
|
1 chunk |
+3 lines, -2 lines |
0 comments
|
Download
|
|
M |
chromecast/media/cma/test/demuxer_stream_for_test.cc
|
View
|
1
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
chromecast/media/cma/test/mock_frame_provider.cc
|
View
|
1
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
content/renderer/pepper/video_decoder_shim.cc
|
View
|
1
|
2 chunks |
+15 lines, -18 lines |
0 comments
|
Download
|
|
M |
media/base/test_helpers.cc
|
View
|
1
|
1 chunk |
+3 lines, -2 lines |
0 comments
|
Download
|
|
M |
media/base/video_decoder_config.h
|
View
|
1
|
2 chunks |
+15 lines, -8 lines |
0 comments
|
Download
|
|
M |
media/base/video_decoder_config.cc
|
View
|
1
|
3 chunks |
+4 lines, -35 lines |
0 comments
|
Download
|
|
M |
media/base/video_types.h
|
View
|
1
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
media/cast/sender/h264_vt_encoder_unittest.cc
|
View
|
1
|
1 chunk |
+3 lines, -2 lines |
0 comments
|
Download
|
|
M |
media/ffmpeg/ffmpeg_common.h
|
View
|
1
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
media/ffmpeg/ffmpeg_common.cc
|
View
|
1
|
2 chunks |
+28 lines, -6 lines |
0 comments
|
Download
|
|
M |
media/filters/decrypting_demuxer_stream.cc
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
media/filters/ffmpeg_video_decoder.cc
|
View
|
1
|
1 chunk |
+8 lines, -4 lines |
0 comments
|
Download
|
|
M |
media/filters/ffmpeg_video_decoder_unittest.cc
|
View
|
1
|
7 chunks |
+10 lines, -3 lines |
0 comments
|
Download
|
|
M |
media/filters/vpx_video_decoder.cc
|
View
|
1
|
2 chunks |
+6 lines, -1 line |
0 comments
|
Download
|
|
M |
media/formats/mp2t/es_adapter_video_unittest.cc
|
View
|
1
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
media/formats/mp2t/es_parser_h264.cc
|
View
|
1
|
1 chunk |
+3 lines, -2 lines |
0 comments
|
Download
|
|
M |
media/formats/mp4/mp4_stream_parser.cc
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
media/formats/webm/webm_video_client.cc
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
media/mojo/interfaces/media_types.mojom
|
View
|
1
|
3 chunks |
+11 lines, -1 line |
0 comments
|
Download
|
|
M |
media/mojo/services/media_type_converters.cc
|
View
|
1
|
3 chunks |
+13 lines, -2 lines |
0 comments
|
Download
|
|
A |
media/test/data/blackwhite_yuv420p_rec709.mp4
|
View
|
|
Binary file |
0 comments
|
Download
|
Total messages: 18 (8 generated)
|