Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1162)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1230583010: Add stronger DCHECK for front and back timestamp calculations. (Closed)

Created:
5 years, 5 months ago by DaleCurtis
Modified:
5 years, 5 months ago
Reviewers:
jrummell
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add stronger DCHECK for front and back timestamp calculations. BUG=481640 TEST=none Committed: https://crrev.com/7a15b697ad60df43cc9f4dcd9c0044b59b8a0aff Cr-Commit-Position: refs/heads/master@{#338209}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M media/filters/audio_clock.cc View 2 chunks +11 lines, -0 lines 2 comments Download

Messages

Total messages: 8 (2 generated)
DaleCurtis
5 years, 5 months ago (2015-07-09 23:49:53 UTC) #2
jrummell
lgtm https://codereview.chromium.org/1230583010/diff/1/media/filters/audio_clock.cc File media/filters/audio_clock.cc (right): https://codereview.chromium.org/1230583010/diff/1/media/filters/audio_clock.cc#newcode45 media/filters/audio_clock.cc:45: const int64_t original_buffered_frames = total_buffered_frames_; Since this is ...
5 years, 5 months ago (2015-07-10 00:32:58 UTC) #3
DaleCurtis
https://codereview.chromium.org/1230583010/diff/1/media/filters/audio_clock.cc File media/filters/audio_clock.cc (right): https://codereview.chromium.org/1230583010/diff/1/media/filters/audio_clock.cc#newcode45 media/filters/audio_clock.cc:45: const int64_t original_buffered_frames = total_buffered_frames_; On 2015/07/10 00:32:57, jrummell ...
5 years, 5 months ago (2015-07-10 00:34:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1230583010/1
5 years, 5 months ago (2015-07-10 00:36:56 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-10 02:33:27 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-10 02:35:38 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/7a15b697ad60df43cc9f4dcd9c0044b59b8a0aff
Cr-Commit-Position: refs/heads/master@{#338209}

Powered by Google App Engine
This is Rietveld 408576698