Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1230583008: Create a template AutoTAcquire, and specialize an SkMutex version. (Closed)

Created:
5 years, 5 months ago by herb_g
Modified:
5 years, 5 months ago
Reviewers:
mtklein, mtklein_C, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Create a template AutoTAcquire, and specialize an SkMutex version. Add copyright notice. BUG=skia: Committed: https://skia.googlesource.com/skia/+/ac09471140ffc9f7cdf07cfa1a5fdc311b3747b5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -5 lines) Patch
M include/core/SkMutex.h View 3 chunks +16 lines, -5 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
herb_g
5 years, 5 months ago (2015-07-09 18:28:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1230583008/1
5 years, 5 months ago (2015-07-09 18:28:27 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 5 months ago (2015-07-09 18:28:28 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/990)
5 years, 5 months ago (2015-07-09 18:29:49 UTC) #7
herb_g
MikeR the system thinks this is a public API, so you are included.
5 years, 5 months ago (2015-07-09 18:32:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1230583008/1
5 years, 5 months ago (2015-07-09 18:32:43 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/992)
5 years, 5 months ago (2015-07-09 18:34:08 UTC) #13
mtklein
lgtm
5 years, 5 months ago (2015-07-09 18:46:56 UTC) #14
reed1
lgtm
5 years, 5 months ago (2015-07-09 20:41:57 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1230583008/1
5 years, 5 months ago (2015-07-09 20:44:06 UTC) #17
commit-bot: I haz the power
5 years, 5 months ago (2015-07-09 20:44:35 UTC) #18
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ac09471140ffc9f7cdf07cfa1a5fdc311b3747b5

Powered by Google App Engine
This is Rietveld 408576698