Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Unified Diff: javatests/org/chromium/distiller/webdocument/filters/RelevantElementsTest.java

Issue 1230583006: Fix for keeping lists structure (Closed) Base URL: https://github.com/chromium/dom-distiller.git@master
Patch Set: Small code refactor for more appropriate names. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: javatests/org/chromium/distiller/webdocument/filters/RelevantElementsTest.java
diff --git a/javatests/org/chromium/distiller/webdocument/filters/RelevantElementsTest.java b/javatests/org/chromium/distiller/webdocument/filters/RelevantElementsTest.java
index cb92a4cbff40c2f9c43a9e491775766e67751293..ecab452473e606a1eb0aff347dc873ed31b3ab5e 100644
--- a/javatests/org/chromium/distiller/webdocument/filters/RelevantElementsTest.java
+++ b/javatests/org/chromium/distiller/webdocument/filters/RelevantElementsTest.java
@@ -5,12 +5,11 @@
package org.chromium.distiller.webdocument.filters;
import org.chromium.distiller.DomDistillerJsTestCase;
-import org.chromium.distiller.webdocument.TestWebTextBuilder;
+import org.chromium.distiller.webdocument.PlaceHolder;
import org.chromium.distiller.webdocument.TestWebDocumentBuilder;
import org.chromium.distiller.webdocument.WebDocument;
import org.chromium.distiller.webdocument.WebElement;
import org.chromium.distiller.webdocument.WebImage;
-import org.chromium.distiller.webdocument.WebText;
import org.chromium.distiller.webdocument.WebTable;
@@ -79,4 +78,78 @@ public class RelevantElementsTest extends DomDistillerJsTestCase {
assertFalse(RelevantElements.process(document));
assertFalse(wi.getIsContent());
}
+
+ public void testRelevantOrderedList() {
+ TestWebDocumentBuilder builder = new TestWebDocumentBuilder();
+ PlaceHolder placeHolder = builder.addListStart();
wychen 2015/08/01 01:00:20 nitpick: rename placeHolder to olStart?
+ PlaceHolder liStart = builder.addListStart();
+ builder.addText("text 1").setIsContent(true);
+ PlaceHolder liEnd = builder.addListEnd();
+ PlaceHolder liStart2 = builder.addListStart();
+ builder.addText("text 2").setIsContent(true);
+ PlaceHolder liEnd2 = builder.addListEnd();
+ PlaceHolder liStart3 = builder.addListStart();
+ builder.addText("text 3").setIsContent(true);
+ PlaceHolder liEnd3 = builder.addListEnd();
+ PlaceHolder olEnd = builder.addListEnd();
+ WebDocument document = builder.build();
+ assertTrue(RelevantElements.process(document));
+ assertTrue(placeHolder.getIsContent());
+ assertTrue(liStart.getIsContent());
+ assertTrue(liEnd.getIsContent());
+ assertTrue(liStart2.getIsContent());
+ assertTrue(liEnd2.getIsContent());
+ assertTrue(liStart3.getIsContent());
+ assertTrue(liEnd3.getIsContent());
+ assertTrue(olEnd.getIsContent());
+ }
+
+ public void testRelevantUnorderedList() {
+ TestWebDocumentBuilder builder = new TestWebDocumentBuilder();
+ PlaceHolder ulStart = builder.addListStart();
+ PlaceHolder liStart = builder.addListStart();
+ builder.addText("text 1").setIsContent(true);
+ PlaceHolder liEnd = builder.addListEnd();
+ PlaceHolder liStart2 = builder.addListStart();
+ builder.addText("text 2").setIsContent(true);
wychen 2015/08/01 01:00:20 We should make some items non-content.
+ PlaceHolder liEnd2 = builder.addListEnd();
+ PlaceHolder liStart3 = builder.addListStart();
+ builder.addText("text 3").setIsContent(true);
+ PlaceHolder liEnd3 = builder.addListEnd();
+ PlaceHolder ulEnd = builder.addListEnd();
+ WebDocument document = builder.build();
+ assertTrue(RelevantElements.process(document));
+ assertTrue(ulStart.getIsContent());
+ assertTrue(liStart.getIsContent());
+ assertTrue(liEnd.getIsContent());
+ assertTrue(liStart2.getIsContent());
+ assertTrue(liEnd2.getIsContent());
+ assertTrue(liStart3.getIsContent());
+ assertTrue(liEnd3.getIsContent());
+ assertTrue(ulEnd.getIsContent());
+ }
+
+ public void testRelevantNestedList() {
wychen 2015/08/01 01:00:20 We should make some of the items non-content, and
+ TestWebDocumentBuilder builder = new TestWebDocumentBuilder();
+ PlaceHolder ulStart = builder.addListStart();
+ PlaceHolder liStart = builder.addListStart();
+ builder.addText("text 1").setIsContent(true);
+ PlaceHolder liEnd = builder.addListEnd();
+ PlaceHolder olStart = builder.addListStart();
+ PlaceHolder liOLStart = builder.addListStart();
+ builder.addText("text 2").setIsContent(true);
+ PlaceHolder liOLEnd = builder.addListEnd();
+ PlaceHolder olEnd = builder.addListEnd();
+ PlaceHolder ulEnd = builder.addListEnd();
+ WebDocument document = builder.build();
+ assertTrue(RelevantElements.process(document));
+ assertTrue(ulStart.getIsContent());
+ assertTrue(liStart.getIsContent());
+ assertTrue(olStart.getIsContent());
+ assertTrue(liOLStart.getIsContent());
+ assertTrue(liOLEnd.getIsContent());
+ assertTrue(olEnd.getIsContent());
+ assertTrue(liEnd.getIsContent());
+ assertTrue(ulEnd.getIsContent());
+ }
}

Powered by Google App Engine
This is Rietveld 408576698