Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Unified Diff: java/org/chromium/distiller/webdocument/DomConverter.java

Issue 1230583006: Fix for keeping lists structure (Closed) Base URL: https://github.com/chromium/dom-distiller.git@master
Patch Set: Classes were documented. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: java/org/chromium/distiller/webdocument/DomConverter.java
diff --git a/java/org/chromium/distiller/webdocument/DomConverter.java b/java/org/chromium/distiller/webdocument/DomConverter.java
index 96c9c4b21a1cd3e240b4a2468ffc34e81f519bde..7dc7244afb8ba11e2e8c2588ec48610d1903178b 100644
--- a/java/org/chromium/distiller/webdocument/DomConverter.java
+++ b/java/org/chromium/distiller/webdocument/DomConverter.java
@@ -100,6 +100,11 @@ public class DomConverter implements DomWalker.Visitor {
}
switch (e.getTagName()) {
+ case "OL":
+ case "UL":
+ case "LI":
+ builder.tag(new WebTag(e.getTagName(), WebTag.TagType.START));
wychen 2015/08/11 00:12:15 We could move this out of the switch and use canBe
Marcelo Correa 2015/08/11 00:21:01 Sure, But this wouldn't change the pattern how the
+ break;
case "BR":
builder.lineBreak(e);
return false;
@@ -142,6 +147,16 @@ public class DomConverter implements DomWalker.Visitor {
@Override
public void exit(Node n) {
+ if (n.getNodeType() == Node.ELEMENT_NODE) {
+ Element e = Element.as(n);
+ switch (e.getTagName()) {
+ case "OL":
+ case "UL":
+ case "LI":
+ builder.tag(new WebTag(e.getTagName(), WebTag.TagType.END));
wychen 2015/08/11 00:12:15 And here.
+ break;
+ }
+ }
builder.endElement();
}

Powered by Google App Engine
This is Rietveld 408576698