Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(804)

Unified Diff: javatests/org/chromium/distiller/webdocument/filters/RelevantElementsTest.java

Issue 1230583006: Fix for keeping lists structure (Closed) Base URL: https://github.com/chromium/dom-distiller.git@master
Patch Set: Using a new approach to keep list structure. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: javatests/org/chromium/distiller/webdocument/filters/RelevantElementsTest.java
diff --git a/javatests/org/chromium/distiller/webdocument/filters/RelevantElementsTest.java b/javatests/org/chromium/distiller/webdocument/filters/RelevantElementsTest.java
index cb92a4cbff40c2f9c43a9e491775766e67751293..705dfd916fa5ce0cd145103d23e55cc419556d70 100644
--- a/javatests/org/chromium/distiller/webdocument/filters/RelevantElementsTest.java
+++ b/javatests/org/chromium/distiller/webdocument/filters/RelevantElementsTest.java
@@ -12,6 +12,8 @@ import org.chromium.distiller.webdocument.WebElement;
import org.chromium.distiller.webdocument.WebImage;
import org.chromium.distiller.webdocument.WebText;
import org.chromium.distiller.webdocument.WebTable;
+import org.chromium.distiller.webdocument.PlaceHolderStart;
+import org.chromium.distiller.webdocument.PlaceHolderEnd;
public class RelevantElementsTest extends DomDistillerJsTestCase {
@@ -79,4 +81,78 @@ public class RelevantElementsTest extends DomDistillerJsTestCase {
assertFalse(RelevantElements.process(document));
assertFalse(wi.getIsContent());
}
+
+ public void testRelevantOrderedList() {
+ TestWebDocumentBuilder builder = new TestWebDocumentBuilder();
+ PlaceHolderStart olStart = builder.addOLStart();
+ PlaceHolderStart liStart = builder.addLIStart();
+ builder.addText("text 1").setIsContent(true);
+ PlaceHolderEnd liEnd = builder.addLIEnd();
+ PlaceHolderStart liStart2 = builder.addLIStart();
+ builder.addText("text 2").setIsContent(true);
+ PlaceHolderEnd liEnd2 = builder.addLIEnd();
+ PlaceHolderStart liStart3 = builder.addLIStart();
+ builder.addText("text 3").setIsContent(true);
+ PlaceHolderEnd liEnd3 = builder.addLIEnd();
+ PlaceHolderEnd olEnd = builder.addOLEnd();
+ WebDocument document = builder.build();
+ assertTrue(RelevantElements.process(document));
+ assertTrue(olStart.getIsContent());
+ assertTrue(liStart.getIsContent());
+ assertTrue(liEnd.getIsContent());
+ assertTrue(liStart2.getIsContent());
+ assertTrue(liEnd2.getIsContent());
+ assertTrue(liStart3.getIsContent());
+ assertTrue(liEnd3.getIsContent());
+ assertTrue(olEnd.getIsContent());
+ }
+
+ public void testRelevantUnorderedList() {
+ TestWebDocumentBuilder builder = new TestWebDocumentBuilder();
+ PlaceHolderStart ulStart = builder.addULStart();
+ PlaceHolderStart liStart = builder.addLIStart();
+ builder.addText("text 1").setIsContent(true);
+ PlaceHolderEnd liEnd = builder.addLIEnd();
+ PlaceHolderStart liStart2 = builder.addLIStart();
+ builder.addText("text 2").setIsContent(true);
+ PlaceHolderEnd liEnd2 = builder.addLIEnd();
+ PlaceHolderStart liStart3 = builder.addLIStart();
+ builder.addText("text 3").setIsContent(true);
+ PlaceHolderEnd liEnd3 = builder.addLIEnd();
+ PlaceHolderEnd ulEnd = builder.addULEnd();
+ WebDocument document = builder.build();
+ assertTrue(RelevantElements.process(document));
+ assertTrue(ulStart.getIsContent());
+ assertTrue(liStart.getIsContent());
+ assertTrue(liEnd.getIsContent());
+ assertTrue(liStart2.getIsContent());
+ assertTrue(liEnd2.getIsContent());
+ assertTrue(liStart3.getIsContent());
+ assertTrue(liEnd3.getIsContent());
+ assertTrue(ulEnd.getIsContent());
+ }
+
+ public void testRelevantNestedList() {
+ TestWebDocumentBuilder builder = new TestWebDocumentBuilder();
+ PlaceHolderStart ulStart = builder.addULStart();
+ PlaceHolderStart liStart = builder.addLIStart();
+ builder.addText("text 1").setIsContent(true);
+ PlaceHolderEnd liEnd = builder.addLIEnd();
+ PlaceHolderStart olStart = builder.addOLStart();
+ PlaceHolderStart liOLStart = builder.addLIStart();
+ builder.addText("text 2").setIsContent(true);
+ PlaceHolderEnd liOLEnd = builder.addLIEnd();
+ PlaceHolderEnd olEnd = builder.addOLEnd();
+ PlaceHolderEnd ulEnd = builder.addULEnd();
+ WebDocument document = builder.build();
+ assertTrue(RelevantElements.process(document));
+ assertTrue(ulStart.getIsContent());
+ assertTrue(liStart.getIsContent());
+ assertTrue(olStart.getIsContent());
+ assertTrue(liOLStart.getIsContent());
+ assertTrue(liOLEnd.getIsContent());
+ assertTrue(olEnd.getIsContent());
+ assertTrue(liEnd.getIsContent());
+ assertTrue(ulEnd.getIsContent());
+ }
}

Powered by Google App Engine
This is Rietveld 408576698