Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Unified Diff: java/org/chromium/distiller/webdocument/DomConverter.java

Issue 1230583006: Fix for keeping lists structure (Closed) Base URL: https://github.com/chromium/dom-distiller.git@master
Patch Set: Using a new approach to keep list structure. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: java/org/chromium/distiller/webdocument/DomConverter.java
diff --git a/java/org/chromium/distiller/webdocument/DomConverter.java b/java/org/chromium/distiller/webdocument/DomConverter.java
index 96c9c4b21a1cd3e240b4a2468ffc34e81f519bde..8a749bc0949c49903f7e3e0579ece223094894e9 100644
--- a/java/org/chromium/distiller/webdocument/DomConverter.java
+++ b/java/org/chromium/distiller/webdocument/DomConverter.java
@@ -19,7 +19,6 @@ import org.chromium.distiller.extractors.embeds.ImageExtractor;
import org.chromium.distiller.extractors.embeds.TwitterExtractor;
import org.chromium.distiller.extractors.embeds.VimeoExtractor;
import org.chromium.distiller.extractors.embeds.YouTubeExtractor;
-
import java.util.ArrayList;
import java.util.HashSet;
import java.util.List;
@@ -100,6 +99,15 @@ public class DomConverter implements DomWalker.Visitor {
}
switch (e.getTagName()) {
+ case "OL":
+ builder.embed(new OLStart());
mdjones 2015/07/29 17:12:16 I think using the "embed" method here is a bit amb
+ break;
+ case "UL":
+ builder.embed(new ULStart());
+ break;
+ case "LI":
+ builder.embed(new LIStart());
+ break;
case "BR":
builder.lineBreak(e);
return false;
@@ -142,6 +150,20 @@ public class DomConverter implements DomWalker.Visitor {
@Override
public void exit(Node n) {
+ if (n.getNodeType() == Node.ELEMENT_NODE) {
+ Element e = Element.as(n);
+ switch (e.getTagName()) {
+ case "OL":
+ builder.embed(new OLEnd());
+ break;
+ case "UL":
+ builder.embed(new ULEnd());
+ break;
+ case "LI":
+ builder.embed(new LIEnd());
+ break;
+ }
+ }
builder.endElement();
}

Powered by Google App Engine
This is Rietveld 408576698