Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Side by Side Diff: Source/web/WebHelperPluginImpl.h

Issue 1230533002: Fix virtual/override/final usage in Source/web/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/web/WebFontImpl.h ('k') | Source/web/WebKit.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 class WebPluginContainerImpl; 46 class WebPluginContainerImpl;
47 47
48 // Utility class to host helper plugins for media. Internally, it creates a deta ched 48 // Utility class to host helper plugins for media. Internally, it creates a deta ched
49 // HTMLPluginElement to host the plugin and uses FrameLoaderClient::createPlugin () to instantiate 49 // HTMLPluginElement to host the plugin and uses FrameLoaderClient::createPlugin () to instantiate
50 // the requested plugin. 50 // the requested plugin.
51 class WebHelperPluginImpl final : public WebHelperPlugin { 51 class WebHelperPluginImpl final : public WebHelperPlugin {
52 WTF_MAKE_NONCOPYABLE(WebHelperPluginImpl); 52 WTF_MAKE_NONCOPYABLE(WebHelperPluginImpl);
53 WTF_MAKE_FAST_ALLOCATED(WebHelperPluginImpl); 53 WTF_MAKE_FAST_ALLOCATED(WebHelperPluginImpl);
54 public: 54 public:
55 // WebHelperPlugin methods: 55 // WebHelperPlugin methods:
56 virtual WebPlugin* getPlugin() override; 56 WebPlugin* getPlugin() override;
57 virtual void destroy() override; 57 void destroy() override;
58 58
59 private: 59 private:
60 friend class WebHelperPlugin; 60 friend class WebHelperPlugin;
61 61
62 WebHelperPluginImpl(); 62 WebHelperPluginImpl();
63 virtual ~WebHelperPluginImpl(); 63 ~WebHelperPluginImpl() override;
64 64
65 bool initialize(const String& pluginType, WebLocalFrameImpl*); 65 bool initialize(const String& pluginType, WebLocalFrameImpl*);
66 void reallyDestroy(Timer<WebHelperPluginImpl>*); 66 void reallyDestroy(Timer<WebHelperPluginImpl>*);
67 67
68 Timer<WebHelperPluginImpl> m_destructionTimer; 68 Timer<WebHelperPluginImpl> m_destructionTimer;
69 RefPtrWillBePersistent<HTMLObjectElement> m_objectElement; 69 RefPtrWillBePersistent<HTMLObjectElement> m_objectElement;
70 RefPtrWillBePersistent<WebPluginContainerImpl> m_pluginContainer; 70 RefPtrWillBePersistent<WebPluginContainerImpl> m_pluginContainer;
71 }; 71 };
72 72
73 } // namespace blink 73 } // namespace blink
74 74
75 #endif // WebHelperPluginImpl_h 75 #endif // WebHelperPluginImpl_h
OLDNEW
« no previous file with comments | « Source/web/WebFontImpl.h ('k') | Source/web/WebKit.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698