Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1258)

Unified Diff: chrome/browser/download/download_extensions.cc

Issue 1230483005: [SafeBrowsing] Send pingbacks for additional file types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@more-dangerous-files
Patch Set: Also .dll Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/safe_browsing/download_protection_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/download_extensions.cc
diff --git a/chrome/browser/download/download_extensions.cc b/chrome/browser/download/download_extensions.cc
index da10aec67470e6b40476009a7ed572572369df94..54adce8ffd4fd9ac752e10aeb8b06587d3851ca5 100644
--- a/chrome/browser/download/download_extensions.cc
+++ b/chrome/browser/download/download_extensions.cc
@@ -209,7 +209,9 @@ const struct FileType {
// privileges.
{"js", ALLOW_ON_USER_GESTURE, DISALLOW_AUTO_OPEN},
- // JScript encoded script file.
+ // JScript encoded script file. Usually produced by running Microsoft Script
+ // Encoder over a .js file.
+ // See https://msdn.microsoft.com/library/d14c8zsc.aspx
{"jse", ALLOW_ON_USER_GESTURE, DISALLOW_AUTO_OPEN},
// Shortcuts. May open anything.
@@ -291,15 +293,19 @@ const struct FileType {
{"reg", ALLOW_ON_USER_GESTURE, DISALLOW_AUTO_OPEN},
// Microsoft Windows Explorer Command.
+ // See https://support.microsoft.com/kb/190355 for an example.
{"scf", ALLOW_ON_USER_GESTURE, ALLOW_AUTO_OPEN},
// Microsoft Windows Screen Saver.
{"scr", ALLOW_ON_USER_GESTURE, DISALLOW_AUTO_OPEN},
// Microsoft Windows Script Component. Microsoft FoxPro Screen.
+ // A Script Component is a COM component created using script.
+ // See https://msdn.microsoft.com/library/aa233148.aspx for an example.
{"sct", ALLOW_ON_USER_GESTURE, ALLOW_AUTO_OPEN},
// Microsoft Windows Shortcut into a document.
+ // See https://support.microsoft.com/kb/212344
{"shb", ALLOW_ON_USER_GESTURE, ALLOW_AUTO_OPEN},
// Shell Scrap Object File.
« no previous file with comments | « no previous file | chrome/browser/safe_browsing/download_protection_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698