Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1230473006: [turbofan] Use NumAllocatableRegisters() instead of kMaxNumAllocatableRegisters. (Closed)

Created:
5 years, 5 months ago by rmcilroy
Modified:
5 years, 5 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev, picksi1, oth
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Use NumAllocatableRegisters() instead of kMaxNumAllocatableRegisters. Use NumAllocatableRegisters() instead of kMaxNumAllocatableRegisters in ArchDefaultRegisterConfiguration::ArchDefaultRegisterConfiguration() otherwise the compiler DCHECKS if triggered during snapshot builds on Arm where only 16 DoubleRegisters are avaiable instead of 32. BUG=v8:4280 LOG=N Committed: https://crrev.com/a4584c07e77bc0f5bf7fc2ee73a2194954fa64d4 Cr-Commit-Position: refs/heads/master@{#29548}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M src/compiler/register-configuration.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1230473006/1
5 years, 5 months ago (2015-07-08 15:26:02 UTC) #2
rmcilroy
This cropped up when I was generating the interpreter prototype in the snapshot. I'm not ...
5 years, 5 months ago (2015-07-08 15:27:12 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-08 15:48:29 UTC) #6
Benedikt Meurer
lgtm
5 years, 5 months ago (2015-07-08 19:11:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1230473006/1
5 years, 5 months ago (2015-07-09 09:12:39 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-09 09:14:37 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-07-09 09:14:48 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a4584c07e77bc0f5bf7fc2ee73a2194954fa64d4
Cr-Commit-Position: refs/heads/master@{#29548}

Powered by Google App Engine
This is Rietveld 408576698