Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 123043002: Use the tall header for restored browser popups (Closed)

Created:
6 years, 11 months ago by pkotwicz
Modified:
6 years, 11 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org, tfarina
Visibility:
Public.

Description

Use the tall header for restored browser popups. The new header design uses significantly different assets for the headers of browser and non browser windows. Thus it makes sense for popup browser windows to use the tall header like restored tabbed browser windows do. BUG=297187 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243650

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M ash/wm/caption_buttons/frame_caption_button.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
pkotwicz
James, PTAL
6 years, 11 months ago (2014-01-01 03:29:34 UTC) #1
James Cook
The code of course is fine, but do you have screen shots or a design ...
6 years, 11 months ago (2014-01-06 17:47:37 UTC) #2
pkotwicz
James, I think sgabriel@ has shared the design doc with you. - https://drive.google.com/a/google.com/?usp=folder#folders/0B6x6iYCtKinEQ3dWTHhTcXYwbEk I am ...
6 years, 11 months ago (2014-01-08 06:47:57 UTC) #3
James Cook
LGTM. As I mentioned in person, I think it makes sense for popups to look ...
6 years, 11 months ago (2014-01-08 17:17:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/123043002/1
6 years, 11 months ago (2014-01-08 17:35:04 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-08 21:37:04 UTC) #6
Message was sent while issue was closed.
Change committed as 243650

Powered by Google App Engine
This is Rietveld 408576698