Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 1230423003: Make skyx files for fitness and cards actually build (Closed)

Created:
5 years, 5 months ago by eseidel
Modified:
5 years, 5 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M sky/sdk/example/demo_launcher/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M sky/sdk/example/demo_launcher/apk/org/domokit/sky/demo/SkyDemoApplication.java View 1 chunk +2 lines, -1 line 0 comments Download
M sky/sdk/example/fitness/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm
5 years, 5 months ago (2015-07-16 17:13:02 UTC) #2
eseidel
5 years, 5 months ago (2015-07-16 17:14:25 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5f5dfcc9af8b40a14dd76e34c60a5766b9f58bb4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698