Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4112)

Unified Diff: chrome/browser/ui/webui/sync_setup_handler.cc

Issue 12304039: Merge 182342 (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1410/src/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/sync_setup_handler.cc
===================================================================
--- chrome/browser/ui/webui/sync_setup_handler.cc (revision 183345)
+++ chrome/browser/ui/webui/sync_setup_handler.cc (working copy)
@@ -1201,9 +1201,16 @@
// this as if the user closed the tab. However, don't actually close the tab
// since the user is doing something with it. Disconnect and forget about it
// before closing down the sync setup.
- // Ignore navigations to about:blank since that can happen during sign in.
+ // The one exception is the expected continue URL. If the user lands there,
+ // this means sign in was successful.
const GURL& url = active_gaia_signin_tab_->GetURL();
- if (url != GURL("about:blank") && !gaia::IsGaiaSignonRealm(url.GetOrigin())) {
+ const GURL continue_url =
+ SyncPromoUI::GetNextPageURLForSyncPromoURL(
+ SyncPromoUI::GetSyncPromoURL(GURL(),
+ SyncPromoUI::SOURCE_SETTINGS,
+ false));
+
+ if (url != continue_url && !gaia::IsGaiaSignonRealm(url.GetOrigin())) {
content::WebContentsObserver::Observe(NULL);
active_gaia_signin_tab_ = NULL;
CloseSyncSetup();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698