Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2827)

Unified Diff: chrome/browser/extensions/api/debugger/debugger_api_constants.cc

Issue 12304021: Allow chrome.debugger API to attach to extension background pages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More descriptive flag name. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/debugger/debugger_api_constants.cc
diff --git a/chrome/browser/extensions/api/debugger/debugger_api_constants.cc b/chrome/browser/extensions/api/debugger/debugger_api_constants.cc
index bbd5cf8d6b6cd136a29f469221c9778b4c84e511..40ae779cda6b9c9be84cce30856edc4ccbb12250 100644
--- a/chrome/browser/extensions/api/debugger/debugger_api_constants.cc
+++ b/chrome/browser/extensions/api/debugger/debugger_api_constants.cc
@@ -10,13 +10,20 @@ const char kOnEvent[] = "debugger.onEvent";
const char kOnDetach[] = "debugger.onDetach";
const char kAlreadyAttachedError[] =
- "Another debugger is already attached to the tab with id: *.";
+ "Another debugger is already attached to the * with id: *.";
const char kAttachToWebUIError[] =
"Can not attach to the page with the \"*://\" scheme.";
-const char kNoTabError[] = "No tab with given id *.";
+const char kNoTargetError[] = "No * with given id *.";
+const char kInvalidTargetError[] =
+ "Either tab id or extension id must be specified.";
const char kNotAttachedError[] =
- "Debugger is not attached to the tab with id: *.";
+ "Debugger is not attached to the * with id: *.";
const char kProtocolVersionNotSupportedError[] =
"Requested protocol version is not supported: *.";
+const char kSilentDebuggingRequired[] =
+ "Cannot attach to an extension unless '*' flag is enabled.";
+
+const char kTabTargetType[] = "tab";
+const char kExtensionTargetType[] = "extension";
} // namespace debugger_api_constants

Powered by Google App Engine
This is Rietveld 408576698