Issue 12304006: When inlining, create a new local handler, to avoid polluting the local handler of the caller.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12304006: When inlining, create a new local handler, to avoid polluting the local handler of the caller. (Closed)

Created:
7 years, 10 months ago by ngeoffray

Modified:
7 years, 10 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

When inlining, create a new local handler, to avoid polluting the local handler of the caller. Committed: https://code.google.com/p/dart/source/detail?r=18620

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -3 lines)			Patch
	M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View	1	4 chunks	+10 lines, -3 lines	0 comments	Download
	A	tests/language/inline_test.dart	View		1 chunk	+25 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

ngeoffray

I had to change the CL to create the inlining state after evaluating the arguments ...

7 years, 10 months ago (2013-02-18 12:31:18 UTC) #3

Still LGTM.