Issue 1230343002: Revert of Removes Vietnamese VNI input method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1230343002: Revert of Removes Vietnamese VNI input method. (Closed)

Created:
5 years, 5 months ago by Shu Chen

Modified:
5 years, 5 months ago

Reviewers:
James Su

CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, arv+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Revert of Removes Vietnamese VNI input method. (patchset #1 id:1 of https://codereview.chromium.org/1144493005/) Reason for revert: Reenabling VNI input method in M46. Original issue's description: > Removes Vietnamese VNI input method. > > TBR=suzhe@chromium.org > BUG=487914 > TEST=Verified on linux_chromeos. > > Committed: https://crrev.com/bd6744223600cc1a00b5bfab38813931665ff83f > Cr-Commit-Position: refs/heads/master@{#329791} TBR=suzhe@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=487914 Committed: https://crrev.com/1be90f759f4cffe50ccc65fe84de3753f8218396 Cr-Commit-Position: refs/heads/master@{#338459}

Created: 5 years, 5 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -0 lines)			Patch
	M	chrome/browser/resources/chromeos/input_method/google_input_tools_manifest.json	View		1 chunk	+13 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1230343002/1

5 years, 5 months ago (2015-07-13 00:55:45 UTC) #2

commit-bot: I haz the power

5 years, 5 months ago (2015-07-13 00:57:28 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/1be90f759f4cffe50ccc65fe84de3753f8218396
Cr-Commit-Position: refs/heads/master@{#338459}