[Android] Make enhanced bookmark editing UI more straightforward.

chrome/android/java/res/layout/eb_edit.xml

Index: chrome/android/java/res/layout/eb_edit.xml
diff --git a/chrome/android/java/res/layout/eb_edit.xml b/chrome/android/java/res/layout/eb_edit.xml
index 5665c6508bd426f5ffeb2764be8802281e985122..b7830f743576d2109e92cf699df3eed7020cdb59 100644
--- a/chrome/android/java/res/layout/eb_edit.xml
+++ b/chrome/android/java/res/layout/eb_edit.xml
@@ -35,10 +35,20 @@
             android:layout_marginBottom="8dp"
             android:orientation="vertical" >
 
+            <!-- A trick to avoid focusing the below EditText initially. For some reason, setting
+                 android:focusableInTouchMode in the above LinearLayout or ScrollView didn't work
+                 in this context. -->

[Ian Wen, 2015/07/21 19:59:05]

I don't see it is a problem to let title edit text have focus (the keyboard is
already not shown)... Yet if you insist, we could simply make the shadow view
(#19) to be focusable. Also android:focusableInTouch alone should do the job.

[Kibeom Kim (inactive), 2015/08/04 20:54:04]

not critical for M45 removed.

+            <View
+                android:layout_width="0dp"
+                android:layout_height="0dp"
+                android:focusable="true"

[Ted C, 2015/07/21 20:21:08]

Can you set these values to false on the textviews?  Then when it is attached to
the window or something, we could set them to true to allow them to be focused?

Does this affect accessibility focus traversal?

[Kibeom Kim (inactive), 2015/08/04 20:54:04]

not critical for M45 removed.

+                android:focusableInTouchMode="true" />
+
             <android.support.design.widget.TextInputLayout
                 android:layout_width="match_parent"
-                android:layout_height="wrap_content" >
-
+                android:layout_height="wrap_content"
+                android:layout_marginTop="10dp"
+                android:layout_marginBottom="10dp" >

[Ian Wen, 2015/07/21 19:59:05]

Is there a clear advantage of using margin instead of padding? Are there any
bugs filed for this issue? If not I would prefer keeping things the way it
was...

[Kibeom Kim (inactive), 2015/08/04 20:54:04]

discussed offline

                 <!-- android:text is set here is to avoid UI jumping. -->
                 <org.chromium.chrome.browser.widget.EmptyAlertEditText
                     android:id="@+id/title_text"
@@ -46,7 +56,7 @@
                     android:layout_height="wrap_content"
                     android:hint="@string/bookmark_name"
                     android:text="@string/bookmark_name"
-                    android:imeOptions="flagNoExtractUi"
+                    android:imeOptions="flagNoExtractUi|actionDone"
                     android:inputType="textCapSentences|textAutoCorrect"
                     android:singleLine="true"
                     chrome:alertMessage="@string/bookmark_missing_title" />
@@ -55,26 +65,30 @@
             <TextView
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
-                android:paddingEnd="3dp"
-                android:paddingStart="3dp"
-                android:paddingTop="8dp"
+                android:layout_marginTop="10dp"
+                android:layout_marginBottom="8dp"
+                android:layout_marginStart="3dp"
+                android:layout_marginEnd="3dp"
                 android:text="@string/bookmark_folder"
-                android:textAppearance="@style/TextAppearance.AppCompat.Small" />
+                android:textAppearance="?android:attr/textAppearanceSmall"
+                android:textSize="12sp" />
 
             <TextView
                 android:id="@+id/folder_text"
                 android:layout_width="match_parent"
                 android:layout_height="wrap_content"
-                android:paddingBottom="8dp"
-                android:paddingEnd="3dp"
-                android:paddingStart="3dp"
-                android:paddingTop="8dp"
-                android:textAppearance="@style/TextAppearance.AppCompat.Medium"
+                android:layout_marginTop="8dp"
+                android:layout_marginBottom="12dp"
+                android:layout_marginStart="3dp"
+                android:layout_marginEnd="3dp"
+                android:textAppearance="?android:attr/textAppearanceMedium"
                 android:textColor="@color/dark_mode_tint" />
 
             <android.support.design.widget.TextInputLayout
                 android:layout_width="match_parent"
-                android:layout_height="wrap_content" >
+                android:layout_height="wrap_content"
+                android:layout_marginTop="10dp"
+                android:layout_marginBottom="10dp" >
 
                 <org.chromium.chrome.browser.widget.EmptyAlertEditText
                     android:id="@+id/url_text"
@@ -82,7 +96,7 @@
                     android:layout_height="wrap_content"
                     android:hint="@string/bookmark_url"
                     android:text="@string/bookmark_url"
-                    android:imeOptions="flagNoExtractUi"
+                    android:imeOptions="flagNoExtractUi|actionDone"
                     android:inputType="textUri"
                     android:singleLine="true"
                     chrome:alertMessage="@string/bookmark_missing_url" />