Chromium Code Reviews| Index: chrome/android/java/src/org/chromium/chrome/browser/widget/EmptyAlertEditText.java |
| diff --git a/chrome/android/java/src/org/chromium/chrome/browser/widget/EmptyAlertEditText.java b/chrome/android/java/src/org/chromium/chrome/browser/widget/EmptyAlertEditText.java |
| index 9fe5e1a2494e2550a78b3c4e092dc09208ed478f..286bb1bb29e6c64336ab05a7e75502916f00fa35 100644 |
| --- a/chrome/android/java/src/org/chromium/chrome/browser/widget/EmptyAlertEditText.java |
| +++ b/chrome/android/java/src/org/chromium/chrome/browser/widget/EmptyAlertEditText.java |
| @@ -43,7 +43,11 @@ public class EmptyAlertEditText extends AppCompatEditText { |
| @Override |
| public void afterTextChanged(Editable s) { |
| - if (s.toString().trim().length() != 0 && getError() != null) setError(null); |
| + if (isValid()) { |
| + if (getError() != null) setError(null); |
| + } else { |
| + setError(mAlertMessage); |
| + } |
| } |
| }); |
| } |
| @@ -63,14 +67,9 @@ public class EmptyAlertEditText extends AppCompatEditText { |
| } |
| /** |
| - * Checks whether the content is empty. If empty, an alert message will be shown. |
| - * @return Whether the content is empty. |
| + * @return Whether the content is valid. |
|
newt (away)
2015/08/10 20:15:43
Please define "valid", or change this to "empty".
Kibeom Kim (inactive)
2015/08/10 21:14:24
Done.
|
| */ |
| - public boolean validate() { |
| - if (getTrimmedText().length() == 0) { |
| - setError(mAlertMessage); |
| - return false; |
| - } |
| - return true; |
| + public boolean isValid() { |
| + return getTrimmedText().length() > 0; |
| } |
| } |