[Android] Make enhanced bookmark editing UI more straightforward.

chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkAddEditFolderActivity.java

Index: chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkAddEditFolderActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkAddEditFolderActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkAddEditFolderActivity.java
index d11691820543d0421c8067cb722ea68f4b47a36e..628d83ef75da7c22cbb9e997b4289202d318fbff 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkAddEditFolderActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkAddEditFolderActivity.java
@@ -185,11 +185,22 @@ public class EnhancedBookmarkAddEditFolderActivity extends EnhancedBookmarkActiv
     @Override
     public boolean onOptionsItemSelected(MenuItem item) {
         if (item.getItemId() == android.R.id.home) {
-            onBackPressed();
+            finish();
             return true;
         } else if (item == mSaveButton) {
             assert mIsAddMode;
-            if (save()) finish();
+
+            if (!mFolderTitle.isValid()) {
+                mFolderTitle.requestFocus();
+                return true;
+            }
+
+            BookmarkId newFolder = mModel.addFolder(mParentId, 0, mFolderTitle.getTrimmedText());
+            Intent intent = new Intent();
+            intent.putExtra(INTENT_CREATED_BOOKMARK, newFolder.toString());
+            setResult(RESULT_OK, intent);
+            finish();
+
             return true;
         } else if (item == mDeleteButton) {
             assert !mIsAddMode;
@@ -203,12 +214,12 @@ public class EnhancedBookmarkAddEditFolderActivity extends EnhancedBookmarkActiv
     }
 
     @Override
-    public void onBackPressed() {
-        if (!mIsAddMode) {
-            if (save()) finish();
-        } else {
-            super.onBackPressed();
+    protected void onPause() {

[newt (away), 2015/08/10 20:15:43]

onStop() is a more normal place to save program state. It's guaranteed to be
called when the activity goes away, and won't be called as many times as
onPause() (which happens when a window appears above the activity, or when the
user slides down the notification bar, etc). Use onStop() instead?

[Kibeom Kim (inactive), 2015/08/10 21:14:24]

Done.

+        if (!mIsAddMode && mFolderTitle.isValid()) {
+            mModel.setBookmarkTitle(mFolderId, mFolderTitle.getTrimmedText());
         }
+
+        super.onPause();
     }
 
     @Override
@@ -230,25 +241,6 @@ public class EnhancedBookmarkAddEditFolderActivity extends EnhancedBookmarkActiv
         mModel = null;
     }
 
-    private boolean save() {
-        if (!mFolderTitle.validate()) {
-            mFolderTitle.requestFocus();
-            return false;
-        }
-
-        String folderTitle = mFolderTitle.getTrimmedText();
-        if (mIsAddMode) {
-            BookmarkId newFolder = mModel.addFolder(mParentId, 0, folderTitle);
-            Intent intent = new Intent();
-            intent.putExtra(INTENT_CREATED_BOOKMARK, newFolder.toString());
-            setResult(RESULT_OK, intent);
-        } else {
-            mModel.setBookmarkTitle(mFolderId, folderTitle);
-        }
-
-        return true;
-    }
-
     private void updateParent(BookmarkId newParent) {
         mParentId = newParent;
         mParentTextView.setText(mModel.getBookmarkTitle(mParentId));