Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 <?xml version="1.0" encoding="utf-8"?> | 1 <?xml version="1.0" encoding="utf-8"?> |
| 2 <!-- | 2 <!-- |
| 3 Copyright 2015 The Chromium Authors. All rights reserved. | 3 Copyright 2015 The Chromium Authors. All rights reserved. |
| 4 Use of this source code is governed by a BSD-style license that can be | 4 Use of this source code is governed by a BSD-style license that can be |
| 5 found in the LICENSE file. | 5 found in the LICENSE file. |
| 6 --> | 6 --> |
| 7 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android" | 7 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android" |
| 8 xmlns:chrome="http://schemas.android.com/apk/res-auto" | 8 xmlns:chrome="http://schemas.android.com/apk/res-auto" |
| 9 android:layout_width="match_parent" | 9 android:layout_width="match_parent" |
| 10 android:layout_height="match_parent" | 10 android:layout_height="match_parent" |
| (...skipping 17 matching lines...) Expand all Loading... | |
| 28 | 28 |
| 29 <LinearLayout | 29 <LinearLayout |
| 30 android:layout_width="match_parent" | 30 android:layout_width="match_parent" |
| 31 android:layout_height="wrap_content" | 31 android:layout_height="wrap_content" |
| 32 android:layout_marginEnd="16dp" | 32 android:layout_marginEnd="16dp" |
| 33 android:layout_marginStart="16dp" | 33 android:layout_marginStart="16dp" |
| 34 android:layout_marginTop="8dp" | 34 android:layout_marginTop="8dp" |
| 35 android:layout_marginBottom="8dp" | 35 android:layout_marginBottom="8dp" |
| 36 android:orientation="vertical" > | 36 android:orientation="vertical" > |
| 37 | 37 |
| 38 <!-- A trick to avoid focusing the below EditText initially. For som e reason, setting | |
|
Ian Wen
2015/07/20 18:41:57
Use SOFT_INPUT_STATE_HIDDEN instead. You can also
Kibeom Kim (inactive)
2015/07/20 20:04:47
Yeah keyboard hiding is already configured in the
| |
| 39 android:focusableInTouchMode in the above LinearLayout or Scrol lView didn't work | |
| 40 in this context. --> | |
| 41 <View | |
| 42 android:layout_width="0dp" | |
| 43 android:layout_height="0dp" | |
| 44 android:focusable="true" | |
| 45 android:focusableInTouchMode="true" /> | |
| 46 | |
| 38 <android.support.design.widget.TextInputLayout | 47 <android.support.design.widget.TextInputLayout |
| 39 android:layout_width="match_parent" | 48 android:layout_width="match_parent" |
| 40 android:layout_height="wrap_content" > | 49 android:layout_height="wrap_content" |
| 41 | 50 android:layout_marginTop="10dp" |
| 51 android:layout_marginBottom="10dp" > | |
|
Ian Wen
2015/07/20 18:41:57
When layouting edittexts, paddings are in general
Kibeom Kim (inactive)
2015/07/20 20:04:47
Actually, that's the reason I used margin because
| |
| 42 <!-- android:text is set here is to avoid UI jumping. --> | 52 <!-- android:text is set here is to avoid UI jumping. --> |
| 43 <org.chromium.chrome.browser.widget.EmptyAlertEditText | 53 <org.chromium.chrome.browser.widget.EmptyAlertEditText |
| 44 android:id="@+id/title_text" | 54 android:id="@+id/title_text" |
| 45 android:layout_width="match_parent" | 55 android:layout_width="match_parent" |
| 46 android:layout_height="wrap_content" | 56 android:layout_height="wrap_content" |
| 47 android:hint="@string/bookmark_name" | 57 android:hint="@string/bookmark_name" |
| 48 android:text="@string/bookmark_name" | 58 android:text="@string/bookmark_name" |
| 49 android:imeOptions="flagNoExtractUi" | 59 android:imeOptions="flagNoExtractUi|actionDone" |
| 50 android:inputType="textCapSentences|textAutoCorrect" | 60 android:inputType="textCapSentences|textAutoCorrect" |
| 51 android:singleLine="true" | 61 android:singleLine="true" |
| 52 chrome:alertMessage="@string/bookmark_missing_title" /> | 62 chrome:alertMessage="@string/bookmark_missing_title" /> |
| 53 </android.support.design.widget.TextInputLayout> | 63 </android.support.design.widget.TextInputLayout> |
| 54 | 64 |
| 55 <TextView | 65 <TextView |
| 56 android:layout_width="wrap_content" | 66 android:layout_width="wrap_content" |
| 57 android:layout_height="wrap_content" | 67 android:layout_height="wrap_content" |
| 58 android:paddingEnd="3dp" | 68 android:layout_marginTop="10dp" |
| 59 android:paddingStart="3dp" | 69 android:layout_marginBottom="8dp" |
| 60 android:paddingTop="8dp" | 70 android:layout_marginStart="3dp" |
| 71 android:layout_marginEnd="3dp" | |
| 61 android:text="@string/bookmark_folder" | 72 android:text="@string/bookmark_folder" |
| 62 android:textAppearance="@style/TextAppearance.AppCompat.Small" / > | 73 android:textAppearance="?android:attr/textAppearanceSmall" |
| 74 android:textSize="12sp" /> | |
| 63 | 75 |
| 64 <TextView | 76 <TextView |
| 65 android:id="@+id/folder_text" | 77 android:id="@+id/folder_text" |
| 66 android:layout_width="match_parent" | 78 android:layout_width="match_parent" |
| 67 android:layout_height="wrap_content" | 79 android:layout_height="wrap_content" |
| 68 android:paddingBottom="8dp" | 80 android:layout_marginTop="8dp" |
| 69 android:paddingEnd="3dp" | 81 android:layout_marginBottom="12dp" |
| 70 android:paddingStart="3dp" | 82 android:layout_marginStart="3dp" |
| 71 android:paddingTop="8dp" | 83 android:layout_marginEnd="3dp" |
| 72 android:textAppearance="@style/TextAppearance.AppCompat.Medium" | 84 android:textAppearance="?android:attr/textAppearanceMedium" |
| 73 android:textColor="@color/dark_mode_tint" /> | 85 android:textColor="@color/dark_mode_tint" /> |
| 74 | 86 |
| 75 <android.support.design.widget.TextInputLayout | 87 <android.support.design.widget.TextInputLayout |
| 76 android:layout_width="match_parent" | 88 android:layout_width="match_parent" |
| 77 android:layout_height="wrap_content" > | 89 android:layout_height="wrap_content" |
| 90 android:layout_marginTop="10dp" | |
| 91 android:layout_marginBottom="10dp" > | |
| 78 | 92 |
| 79 <org.chromium.chrome.browser.widget.EmptyAlertEditText | 93 <org.chromium.chrome.browser.widget.EmptyAlertEditText |
| 80 android:id="@+id/url_text" | 94 android:id="@+id/url_text" |
| 81 android:layout_width="match_parent" | 95 android:layout_width="match_parent" |
| 82 android:layout_height="wrap_content" | 96 android:layout_height="wrap_content" |
| 83 android:hint="@string/bookmark_url" | 97 android:hint="@string/bookmark_url" |
| 84 android:text="@string/bookmark_url" | 98 android:text="@string/bookmark_url" |
| 85 android:imeOptions="flagNoExtractUi" | 99 android:imeOptions="flagNoExtractUi|actionDone" |
| 86 android:inputType="textUri" | 100 android:inputType="textUri" |
| 87 android:singleLine="true" | 101 android:singleLine="true" |
| 88 chrome:alertMessage="@string/bookmark_missing_url" /> | 102 chrome:alertMessage="@string/bookmark_missing_url" /> |
| 89 </android.support.design.widget.TextInputLayout> | 103 </android.support.design.widget.TextInputLayout> |
| 90 </LinearLayout> | 104 </LinearLayout> |
| 91 </ScrollView> | 105 </ScrollView> |
| 92 </LinearLayout> | 106 </LinearLayout> |
| OLD | NEW |